fix(memory): add explicit iterator cleanup to prevent SQLite lock errors (#2265)

Add explicit iter.return() calls in finally blocks for selectFacts() and
getLabels() to ensure prepared statements are properly reset after iteration.

JavaScript for-of loops don't call iterator.return() on normal completion -
only on break/throw/early-return. The @db/sqlite library requires .return()
to properly reset prepared statements. Without it, statements can remain
"active" causing "cannot commit transaction - SQL statements in progress"
errors under concurrent load.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 4.5 <[email protected]>

Author: willkelly

packages/memory/space.ts

@@ -678,17 +678,23 @@ export const selectFacts = function <Space extends MemorySpace>(
   { the, of, cause, is, since }: FactSelector,
 ): SelectedFact[] {
   const stmt = getPreparedStatement(store, "export", EXPORT);
-  const results = [];
-  for (
-    const row of stmt.iter({
-      the: the === SelectAllString ? null : the,
-      of: of === SelectAllString ? null : of,
-      cause: cause === SelectAllString ? null : cause,
-      is: is === undefined ? null : {},
-      since: since ?? null,
-    }) as Iterable<StateRow>
-  ) {
-    results.push(toFact(row));
+  const results: SelectedFact[] = [];
+  const iter = stmt.iter({
+    the: the === SelectAllString ? null : the,
+    of: of === SelectAllString ? null : of,
+    cause: cause === SelectAllString ? null : cause,
+    is: is === undefined ? null : {},
+    since: since ?? null,
+  }) as IterableIterator<StateRow>;
+  // Explicit cleanup via finally - for-of loops don't call return() on normal
+  // completion, leaving the prepared statement active and causing "cannot
+  // commit transaction - SQL statements in progress" errors.
+  try {
+    for (const row of iter) {
+      results.push(toFact(row));
+    }
+  } finally {
+    iter.return?.();
   }
   return results;
 };
@@ -1172,23 +1178,29 @@ export function getLabels<
     "getLabelsBatch",
     GET_LABELS_BATCH,
   );
-  for (
-    const row of stmt.iter({
-      the: LABEL_TYPE,
-      ofs: JSON.stringify(ofs),
-    }) as Iterable<StateRow>
-  ) {
-    const labelFact = toFact(row);
-    set<FactSelectionValue, OfTheCause<FactSelectionValue>>(
-      labels,
-      labelFact.of,
-      labelFact.the,
-      labelFact.cause,
-      {
-        since: labelFact.since,
-        ...(labelFact.is ? { is: labelFact.is } : {}),
-      },
-    );
+  const iter = stmt.iter({
+    the: LABEL_TYPE,
+    ofs: JSON.stringify(ofs),
+  }) as IterableIterator<StateRow>;
+  // Explicit cleanup via finally - for-of loops don't call return() on normal
+  // completion, leaving the prepared statement active and causing "cannot
+  // commit transaction - SQL statements in progress" errors.
+  try {
+    for (const row of iter) {
+      const labelFact = toFact(row);
+      set<FactSelectionValue, OfTheCause<FactSelectionValue>>(
+        labels,
+        labelFact.of,
+        labelFact.the,
+        labelFact.cause,
+        {
+          since: labelFact.since,
+          ...(labelFact.is ? { is: labelFact.is } : {}),
+        },
+      );
+    }
+  } finally {
+    iter.return?.();
   }
 
   return labels;