[OPIK-2927] [P SDK] Add client-side attachment auto-extraction from span/traces inputs and outputs #4353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced `AttachmentDecoder` abstract base class for decoding attachment data. - Added `decoder_helpers` with MIME type detection and file extension utility functions. - Implemented `Base64AttachmentDecoder` for decoding base64-encoded data into `Attachment` objects with MIME-type inspection and file generation logic.
yaricom
added
work in progress
and removed
python
Contributor
SDK E2E Tests Results135 tests ±0 133 ✅ ±0 2m 47s ⏱️ ±0s For more details on these failures, see this check. Results for commit 2e3b847. ± Comparison against base commit 363f146. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
- Added comprehensive unit tests for `detect_mime_type` and `get_file_extension` functions. - Enhanced MIME type handling with improved comments for edge cases. - Updated `decoder_helpers.py` to include clarified comments for better readability.
github-actions
bot
added
the
tests
…tests - Updated `AttachmentDecoder` to enforce stricter type handling for `raw_data`. - Refactored filename generation with new utility: `create_attachment_filename` in `decoder_helpers`. - Added extensive unit tests for `Base64AttachmentDecoder` covering multiple file types and edge cases. - Replaced in-test constants with centralized test data for better reusability. - Refined MIME type detection tests to use shared constants, improving maintainability.
- Introduced `AttachmentWithContext` dataclass to manage attachment metadata. - Implemented `AttachmentsExtractor` for extracting and replacing encoded attachments within data structures. - Included base64 pattern matching and decoding logic for attachment handling. - Added support for context-specific attachment processing with entity type and ID.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Adding attachment extraction logic from input/output data of the logged span/trace objects to reduce load on the backend.
Change checklist
Issues
Testing
Implemented related unit tests
Documentation