Formatting

Author: ricardogobbosouza

src/CurrenciesTrait.php

@@ -79,7 +79,7 @@ public static function setDefaultCurrency($currency)
      */
     public static function getISOCurrencies()
     {
-        return (new ISOCurrencies())->getCurrencies();
+        return (new ISOCurrencies)->getCurrencies();
     }
 
     /**
@@ -118,23 +118,23 @@ private static function makeCurrencies($currenciesConfig)
     {
         if (! $currenciesConfig || ! is_array($currenciesConfig)) {
             // for backward compatibility
-            return new ISOCurrencies();
+            return new ISOCurrencies;
         }
 
         $currenciesList = [];
 
         if ($currenciesConfig['iso'] ?? false) {
             $currenciesList[] = static::makeCurrenciesForSource(
                 $currenciesConfig['iso'],
-                new ISOCurrencies(),
+                new ISOCurrencies,
                 'ISO'
             );
         }
 
         if ($currenciesConfig['bitcoin'] ?? false) {
             $currenciesList[] = static::makeCurrenciesForSource(
                 $currenciesConfig['bitcoin'],
-                new BitcoinCurrencies(),
+                new BitcoinCurrencies,
                 'Bitcoin'
             );
         }

src/Money.php

@@ -98,7 +98,6 @@ public function getAttributes()
     /**
      * Set currency.
      *
-     * @param  \Money\Currency|string  $currency
      * @return \Cknow\Money\Money
      */
     public function setCurrency(\Money\Currency|string $currency)

src/MoneyFormatterTrait.php

@@ -71,7 +71,7 @@ public function formatByAggregate(array $formatters)
      */
     public function formatByBitcoin($fractionDigits = 2, ?Currencies $currencies = null)
     {
-        $formatter = new BitcoinMoneyFormatter($fractionDigits, $currencies ?: new BitcoinCurrencies());
+        $formatter = new BitcoinMoneyFormatter($fractionDigits, $currencies ?: new BitcoinCurrencies);
 
         return $this->formatByFormatter($formatter);
     }

src/MoneySerializerTrait.php

@@ -49,7 +49,7 @@ public function serialize()
      */
     public function serializeByArray()
     {
-        $serializer = new ArrayMoneySerializer();
+        $serializer = new ArrayMoneySerializer;
 
         return $this->serializeBySerializer($serializer);
     }

src/MoneyServiceProvider.php

@@ -34,7 +34,7 @@ public function boot()
         });
 
         Validator::extend('currency', function ($attribute, $value) {
-            $rule = new Rules\Currency();
+            $rule = new Rules\Currency;
 
             return $rule->passes($attribute, $value);
         });

tests/BladeExtensionTest.php

@@ -28,15 +28,15 @@ protected function tearDown(): void
         Mockery::close();
     }
 
-    public function testCurrency()
+    public function test_currency()
     {
         static::assertEquals(
             '<?php echo currency("USD"); ?>',
             $this->compiler->compileString('@currency("USD")')
         );
     }
 
-    public function testMoney()
+    public function test_money()
     {
         static::assertEquals(
             '<?php echo money(500); ?>',
@@ -49,7 +49,7 @@ public function testMoney()
         );
     }
 
-    public function testMoneyMin()
+    public function test_money_min()
     {
         static::assertEquals(
             '<?php echo money_min(money(100), money(200), money(300)); ?>',
@@ -62,7 +62,7 @@ public function testMoneyMin()
         );
     }
 
-    public function testMoneyMax()
+    public function test_money_max()
     {
         static::assertEquals(
             '<?php echo money_max(money(100), money(200), money(300)); ?>',
@@ -75,7 +75,7 @@ public function testMoneyMax()
         );
     }
 
-    public function testMoneyAvg()
+    public function test_money_avg()
     {
         static::assertEquals(
             '<?php echo money_avg(money(100), money(200), money(300)); ?>',
@@ -88,7 +88,7 @@ public function testMoneyAvg()
         );
     }
 
-    public function testMoneySum()
+    public function test_money_sum()
     {
         static::assertEquals(
             '<?php echo money_sum(money(100), money(200), money(300)); ?>',
@@ -101,7 +101,7 @@ public function testMoneySum()
         );
     }
 
-    public function testMoneyParse()
+    public function test_money_parse()
     {
         static::assertEquals(
             '<?php echo money_parse("R$5,00"); ?>',
@@ -114,7 +114,7 @@ public function testMoneyParse()
         );
     }
 
-    public function testMoneyParseByBitcoin()
+    public function test_money_parse_by_bitcoin()
     {
         static::assertEquals(
             '<?php echo money_parse_by_bitcoin("\xC9\x831000.00"); ?>',
@@ -127,7 +127,7 @@ public function testMoneyParseByBitcoin()
         );
     }
 
-    public function testMoneyParseByDecimal()
+    public function test_money_parse_by_decimal()
     {
         static::assertEquals(
             '<?php echo money_parse_by_decimal("5.00", "USD"); ?>',
@@ -140,7 +140,7 @@ public function testMoneyParseByDecimal()
         );
     }
 
-    public function testMoneyParseByIntl()
+    public function test_money_parse_by_intl()
     {
         static::assertEquals(
             '<?php echo money_parse_by_intl("R$5,00"); ?>',
@@ -163,7 +163,7 @@ public function testMoneyParseByIntl()
         );
     }
 
-    public function testMoneyParseByIntlLocalizedDecimal()
+    public function test_money_parse_by_intl_localized_decimal()
     {
         static::assertEquals(
             '<?php echo money_parse_by_intl_localized_decimal("1.00", "USD"); ?>',

tests/Currencies/ISOCurrenciesTest.php

@@ -12,69 +12,69 @@ protected function setUp(): void
         parent::setUp();
     }
 
-    public function testContains()
+    public function test_contains()
     {
-        $currencies = new ISOCurrencies();
+        $currencies = new ISOCurrencies;
         static::assertTrue($currencies->contains(new \Money\Currency('EUR')));
         static::assertTrue($currencies->contains(new \Money\Currency('USD')));
     }
 
-    public function testSubunitFor()
+    public function test_subunit_for()
     {
-        $currencies = new ISOCurrencies();
+        $currencies = new ISOCurrencies;
         static::assertEquals(2, $currencies->subunitFor(new \Money\Currency('EUR')));
         static::assertEquals(2, $currencies->subunitFor(new \Money\Currency('USD')));
     }
 
-    public function testSubunitForInvalidCurrency()
+    public function test_subunit_for_invalid_currency()
     {
         $this->expectException(\Money\Exception\UnknownCurrencyException::class);
         $this->expectExceptionMessage('Cannot find ISO currency XYZ');
 
-        $currencies = new ISOCurrencies();
+        $currencies = new ISOCurrencies;
         $currencies->subunitFor(new \Money\Currency('XYZ'));
     }
 
-    public function testNumericCodeFor()
+    public function test_numeric_code_for()
     {
-        $currencies = new ISOCurrencies();
+        $currencies = new ISOCurrencies;
         static::assertEquals(978, $currencies->numericCodeFor(new \Money\Currency('EUR')));
         static::assertEquals(840, $currencies->numericCodeFor(new \Money\Currency('USD')));
     }
 
-    public function testNumericCodeForInvalidCurrency()
+    public function test_numeric_code_for_invalid_currency()
     {
         $this->expectException(\Money\Exception\UnknownCurrencyException::class);
         $this->expectExceptionMessage('Cannot find ISO currency XYZ');
 
-        $currencies = new ISOCurrencies();
+        $currencies = new ISOCurrencies;
         $currencies->numericCodeFor(new \Money\Currency('XYZ'));
     }
 
-    public function testLoadCurrencies()
+    public function test_load_currencies()
     {
-        $currencies = new ISOCurrencies();
+        $currencies = new ISOCurrencies;
         static::assertContainsOnlyInstancesOf(\Money\Currency::class, $currencies->getIterator());
     }
 
-    public function testGetCurrencies()
+    public function test_get_currencies()
     {
-        $currencies = new ISOCurrencies();
+        $currencies = new ISOCurrencies;
 
         static::assertIsArray($currencies->getCurrencies());
         static::assertArrayHasKey('EUR', $currencies->getCurrencies());
         static::assertArrayHasKey('USD', $currencies->getCurrencies());
         static::assertArrayNotHasKey('XYZ', $currencies->getCurrencies());
     }
 
-    public function testInvalidConfigCurrenciesPath()
+    public function test_invalid_config_currencies_path()
     {
         config(['money.isoCurrenciesPath' => null]);
 
         $this->expectException(\RuntimeException::class);
         $this->expectExceptionMessage('Failed to load currency ISO codes.');
 
-        $currencies = new ISOCurrencies();
+        $currencies = new ISOCurrencies;
 
         $reflection = new \ReflectionObject($currencies);
         $property = $reflection->getProperty('currencies');

tests/CurrenciesTraitTest.php

@@ -19,23 +19,23 @@ private static function currencyListSize(\Money\Currencies $currencies)
         return $size;
     }
 
-    public function testIsValidCurrency()
+    public function test_is_valid_currency()
     {
         $mock = $this->getMockForTrait(CurrenciesTrait::class);
 
         static::assertTrue($mock->isValidCurrency('USD'));
         static::assertTrue($mock->isValidCurrency(new Currency('USD')));
     }
 
-    public function testIsNotValidCurrency()
+    public function test_is_not_valid_currency()
     {
         $mock = $this->getMockForTrait(CurrenciesTrait::class);
 
         static::assertFalse($mock->isValidCurrency('FAIL'));
         static::assertFalse($mock->isValidCurrency(new Currency('FAIL')));
     }
 
-    public function testGetISOCurrencies()
+    public function test_get_iso_currencies()
     {
         $mock = $this->getMockForTrait(CurrenciesTrait::class);
 
@@ -44,24 +44,24 @@ public function testGetISOCurrencies()
         static::assertArrayHasKey('USD', $mock->getISOCurrencies());
     }
 
-    public function testGetCurrencies()
+    public function test_get_currencies()
     {
         $mock = $this->getMockForTrait(CurrenciesTrait::class);
 
         static::assertInstanceOf(\Money\Currencies::class, $mock->getCurrencies());
         static::assertInstanceOf(\Money\Currencies\AggregateCurrencies::class, $mock->getCurrencies());
     }
 
-    public function testSetCurrencies()
+    public function test_set_currencies()
     {
         $mock = $this->getMockForTrait(CurrenciesTrait::class);
-        $mock->setCurrencies(new \Money\Currencies\BitcoinCurrencies());
+        $mock->setCurrencies(new \Money\Currencies\BitcoinCurrencies);
 
         static::assertInstanceOf(\Money\Currencies::class, $mock->getCurrencies());
         static::assertInstanceOf(\Money\Currencies\BitcoinCurrencies::class, $mock->getCurrencies());
     }
 
-    public function testSetCurrenciesCustomCurrencies()
+    public function test_set_currencies_custom_currencies()
     {
         $mock = $this->getMockForTrait(CurrenciesTrait::class);
         $mock->setCurrencies([
@@ -84,7 +84,7 @@ public function testSetCurrenciesCustomCurrencies()
         static::assertEquals(3, $mock->getCurrencies()->subunitFor(new Currency('MY2')));
     }
 
-    public function testSetCurrenciesWrongISOCurrencyCode()
+    public function test_set_currencies_wrong_iso_currency_code()
     {
         $this->expectException(\InvalidArgumentException::class);
         $mock = $this->getMockForTrait(CurrenciesTrait::class);
@@ -98,7 +98,7 @@ public function testSetCurrenciesWrongISOCurrencyCode()
         ]);
     }
 
-    public function testSetCurrenciesWrongBitcoinCurrencyCode()
+    public function test_set_currencies_wrong_bitcoin_currency_code()
     {
         $this->expectException(\InvalidArgumentException::class);
         $mock = $this->getMockForTrait(CurrenciesTrait::class);
@@ -112,17 +112,17 @@ public function testSetCurrenciesWrongBitcoinCurrencyCode()
         ]);
     }
 
-    public function testSetCurrenciesWrongStandardCurrenciesConfig()
+    public function test_set_currencies_wrong_standard_currencies_config()
     {
         $this->expectException(\InvalidArgumentException::class);
         $mock = $this->getMockForTrait(CurrenciesTrait::class);
         $mock->setCurrencies([
-            'iso' => new stdClass(),
+            'iso' => new stdClass,
             'bitcoin' => 'all',
         ]);
     }
 
-    public function testSetCurrenciesEmptyCurrenciesConfig()
+    public function test_set_currencies_empty_currencies_config()
     {
         $mock = $this->getMockForTrait(CurrenciesTrait::class);
         $mock->setCurrencies([
@@ -135,36 +135,36 @@ public function testSetCurrenciesEmptyCurrenciesConfig()
         static::assertEquals(0, static::currencyListSize($mock->getCurrencies()));
     }
 
-    public function testSetCurrenciesDefaultCurrenciesConfig()
+    public function test_set_currencies_default_currencies_config()
     {
         $mock = $this->getMockForTrait(CurrenciesTrait::class);
         $mock->setCurrencies([]);
 
         static::assertInstanceOf(ISOCurrencies::class, $mock->getCurrencies());
     }
 
-    public function testSetCurrenciesAllISOCurrencies()
+    public function test_set_currencies_all_iso_currencies()
     {
         $mock = $this->getMockForTrait(CurrenciesTrait::class);
         $mock->setCurrencies([
             'iso' => 'all',
         ]);
 
         static::assertEquals(
-            new \Money\Currencies\AggregateCurrencies([new ISOCurrencies()]),
+            new \Money\Currencies\AggregateCurrencies([new ISOCurrencies]),
             $mock->getCurrencies()
         );
     }
 
-    public function testSetCurrenciesAllBitcoinCurrencies()
+    public function test_set_currencies_all_bitcoin_currencies()
     {
         $mock = $this->getMockForTrait(CurrenciesTrait::class);
         $mock->setCurrencies([
             'bitcoin' => 'all',
         ]);
 
         static::assertEquals(
-            new \Money\Currencies\AggregateCurrencies([new \Money\Currencies\BitcoinCurrencies()]),
+            new \Money\Currencies\AggregateCurrencies([new \Money\Currencies\BitcoinCurrencies]),
             $mock->getCurrencies()
         );
     }