Fix multiplication and division by a float precision (#127)

* Fix multiplication and division by a float precision

* Fix tests + Add ones concerning issue

Co-authored-by: m.sorce <[email protected]>

Author: marwins

src/Money.php

@@ -103,7 +103,7 @@ public function divide($divisor, $roundingMode = \Money\Money::ROUND_HALF_UP)
         $money = $this->getMoney();
         $calculator = static::resolveCalculator();
 
-        return new self((int) $calculator->divide($money->getAmount(), $divisor), $money->getCurrency());
+        return new self((int) round($calculator->divide($money->getAmount(), $divisor), 0, $roundingMode), $money->getCurrency());
     }
 
     /**
@@ -125,7 +125,7 @@ public function multiply($multiplier, $roundingMode = \Money\Money::ROUND_HALF_U
         $money = $this->getMoney();
         $calculator = static::resolveCalculator();
 
-        return new self((int) $calculator->multiply($money->getAmount(), $multiplier), $money->getCurrency());
+        return new self((int) round($calculator->multiply($money->getAmount(), $multiplier), 0, $roundingMode), $money->getCurrency());
     }
 
     /**

tests/MoneyTest.php

@@ -86,9 +86,10 @@ public function testMultiply()
         static::assertEquals(Money::USD(275), Money::USD(5.5)->multiply(0.5));
         static::assertEquals(Money::USD(1100), Money::USD(5.5)->multiply(2));
         static::assertEquals(Money::USD(10), Money::USD(5)->multiply(2));
-        static::assertEquals(Money::USD(101), Money::USD(35)->multiply(2.9));
+        static::assertEquals(Money::USD(102), Money::USD(35)->multiply(2.9));
         static::assertEquals(Money::USD(10150), Money::USD(35, true)->multiply(2.9));
         static::assertEquals(Money::USD(11550), Money::USD(35, true)->multiply(3.3));
+        static::assertEquals(Money::USD(3317), Money::USD(199, true)->multiply(0.16666667));
     }
 
     public function testDivide()
@@ -97,8 +98,9 @@ public function testDivide()
         static::assertEquals(Money::USD(1010), Money::USD(20.20)->divide(2));
         static::assertEquals(Money::USD(10), Money::USD(20)->divide(2));
         static::assertEquals(Money::USD(0.12), Money::USD(35)->divide(2.9));
-        static::assertEquals(Money::USD(12.06), Money::USD(35, true)->divide(2.9));
-        static::assertEquals(Money::USD(10.60), Money::USD(35, true)->divide(3.3));
+        static::assertEquals(Money::USD(12.07), Money::USD(35, true)->divide(2.9));
+        static::assertEquals(Money::USD(10.61), Money::USD(35, true)->divide(3.3));
+        static::assertEquals(Money::USD(86.52), Money::USD(199, true)->divide(2.3));
     }
 
     public function testMod()