Skip to content

SantanderApiClient receives a configuration class, raising the complexity level to use #15

@avelino

Description

@avelino
client = SantanderApiClient(SantanderClientConfiguration(
  client_id="client_id",
  client_secret="client_pk",
  cert="certificate_path",
  base_url="api_url",
  workspace_id="optional"
))

I understand why we're using a class for client configuration, but this raises the complexity level to use the SDK.
The ideal for an open source project is to be simple and not make the user think too much, e.g.

Need to integrate with XXX, how do I do it? client = ClientClass(... params)

Internally we can use the configuration class, but we shouldn't outsource this to the user.

proposal

client = SantanderApiClient(
  client_id="client_id",
  client_secret="client_pk",
  cert="certificate_path",
  base_url="api_url",
  workspace_id="optional"
)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions