Skip to content

Commit 0eb636c

Browse files
author
your-github-username
committed
Fix QuickSight permissions for DataSources and DataSets
- Apply same permissions to DataSources and DataSets as Dashboards - Renamed dashboard_permissions to asset_permissions for clarity - All three asset types now get proper Principals and Actions arrays
1 parent bbbc98b commit 0eb636c

File tree

1 file changed

+6
-6
lines changed
  • experimental/SMUS-CICD-pipeline-cli/src/smus_cicd/helpers

1 file changed

+6
-6
lines changed

experimental/SMUS-CICD-pipeline-cli/src/smus_cicd/helpers/quicksight.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -208,8 +208,8 @@ def import_dashboard(
208208
else:
209209
job_id = f"import-{timestamp}"
210210

211-
# Build dashboard permissions for OverridePermissions
212-
dashboard_permissions = {}
211+
# Build permissions for OverridePermissions (applies to all asset types)
212+
asset_permissions = {}
213213
if permissions:
214214
principals = []
215215
actions = []
@@ -218,18 +218,18 @@ def import_dashboard(
218218
actions.extend(perm["actions"])
219219
# Remove duplicates from actions
220220
actions = list(set(actions))
221-
dashboard_permissions = {"Principals": principals, "Actions": actions}
221+
asset_permissions = {"Principals": principals, "Actions": actions}
222222

223223
import_params = {
224224
"AwsAccountId": aws_account_id,
225225
"AssetBundleImportJobId": job_id,
226226
"AssetBundleImportSource": {"Body": _download_bundle(bundle_url)},
227227
"FailureAction": "ROLLBACK",
228228
"OverridePermissions": {
229-
"DataSources": [{"DataSourceIds": ["*"], "Permissions": {}}],
230-
"DataSets": [{"DataSetIds": ["*"], "Permissions": {}}],
229+
"DataSources": [{"DataSourceIds": ["*"], "Permissions": asset_permissions}],
230+
"DataSets": [{"DataSetIds": ["*"], "Permissions": asset_permissions}],
231231
"Dashboards": [
232-
{"DashboardIds": ["*"], "Permissions": dashboard_permissions}
232+
{"DashboardIds": ["*"], "Permissions": asset_permissions}
233233
],
234234
},
235235
}

0 commit comments

Comments
 (0)