docs: aggregation #391
Merged
docs: aggregation #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The preview of this PR has been deleted. |
vveiln
approved these changes
Nov 14, 2025
Member
vveiln
left a comment
vveiln
left a comment
There was a problem hiding this comment.
Looks good to me! I left a couple of minor comments
| @@ -1,3 +1,39 @@ | |||
| # Proof aggregation | |||
| An aggregation proof attests to the validity of all compliance and logic proofs of an RM transaction. With aggregation, the [raw RM proofs](../proving/index.md) (except the delta proof) are no longer needed, so they can be erased. Reducing thereby verification time and transaction size. | |||
Member
There was a problem hiding this comment.
are no longer needed
maybe we could change it to "don't need to be stored in the transaction structure", otherwise it sounds like we don't need to prove the proofs
| Passing the raw proofs as witnesses means they are not needed to verify the aggregation proof. This is what allows to remove them from the RM transaction. | ||
|
|
||
| !!! note | ||
| The verifier must be aware of what has been verified by the prover during aggregation. This means the aggregation instance must account for the raw verifying keys and raw instances. However, they do not need to appear explicitly. A _binding_ (and possibly short) commitment suffices. |
Member
There was a problem hiding this comment.
This note explains why we include vks and instances in the instance, right?
Can we rephrase "This means the aggregation instance must account ..." to "That is why we include raw verifying keys.."?
| !!! note | ||
| The verifier must be aware of what has been verified by the prover during aggregation. This means the aggregation instance must account for the raw verifying keys and raw instances. However, they do not need to appear explicitly. A _binding_ (and possibly short) commitment suffices. | ||
| ## Aggregation constraints | ||
| An aggregation must check the following: |
| An aggregation must check the following: | ||
| 1. Verify each compliance proof against its corresponding compliance instance using the compliance verifying key | ||
| 2. Verify each logic proof against its corresponding logic instance using the corresponding logic verifying key | ||
| 2. Other aggregation-specific constraints |
Member
There was a problem hiding this comment.
- the item number should be 3
- Can we specify what constraints?
Author
There was a problem hiding this comment.
- Fixed.
- What I meant is that depending on the aggregation circuit there may be more constraints. (For batch strategy there is no more constraints, for sequential strategy correct accumulation/hashing must be enforced also. The strategies are described below.) I changed the paragraph so hopefully is clearer now.
larraia
force-pushed
the
enrique/aggregation
branch
from
ba60b36 to
8d3c6bb
Compare
larraia
force-pushed
the
enrique/aggregation
branch
from
8d3c6bb to
022e34d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof aggregation.