Convert all .unwraps()s that don't change signatures nor tests

Unwraps that don't change signatures are now converted to being
safer. However this is not everything and further work is
required. Namely tests are not converted, this would normally be fine,
but tests are exported to Elixir and thus have a chance to crash the
VM.

Further functions like:

tests::create_an_action

Have non Result outputs, meaning greater refactoring is required to
handle these.

Author: mariari

arm/src/encryption.rs

@@ -1,3 +1,5 @@
+#[cfg(feature = "nif")]
+use crate::rustler_util::{bincode_deserialize, bincode_serialize};
 use crate::{
     error::ArmError,
     utils::{bytes_to_words, words_to_bytes},
@@ -35,7 +37,7 @@ impl SecretKey {
 
 #[cfg(feature = "nif")]
 fn do_encode<'a>(secret_key: &SecretKey, env: Env<'a>) -> Result<Term<'a>, Error> {
-    let bytes = bincode::serialize(&secret_key.0).unwrap();
+    let bytes = bincode_serialize(&secret_key)?;
 
     let mut erl_bin = OwnedBinary::new(bytes.len()).ok_or(Error::BadArg)?;
     let _ = erl_bin.as_mut_slice().write_all(&bytes);

arm/src/rustler_util.rs

@@ -184,8 +184,7 @@ impl RustlerEncoder for AffinePoint {
 impl<'a> RustlerDecoder<'a> for AffinePoint {
     fn rustler_decode(term: Term<'a>) -> NifResult<Self> {
         let binary: Vec<u8> = RustlerDecoder::rustler_decode(term)?;
-        let affine_point = bincode::deserialize::<AffinePoint>(binary.as_slice());
-        Ok(affine_point.unwrap())
+        bincode_deserialize(&binary)
     }
 }
 
@@ -200,8 +199,7 @@ impl RustlerEncoder for Signature {
 impl<'a> RustlerDecoder<'a> for Signature {
     fn rustler_decode(term: Term<'a>) -> NifResult<Self> {
         let binary: Vec<u8> = RustlerDecoder::rustler_decode(term)?;
-        let signature = bincode::deserialize::<Signature>(binary.as_slice());
-        Ok(signature.unwrap())
+        bincode_deserialize(&binary)
     }
 }