Skip to content

Commit 155c997

Browse files
committed
RDMA/bng_re: Remove prefetch instruction
The prefetch instruction is meant to speed up access to memory referenced by its address argument. In the bng_re code path, it has no effect, because the pointer refers to a function that is executed immediately afterward. The issue was identified due to the following kbuild compilation error: drivers/infiniband/hw/bng_re/bng_fw.c: In function 'bng_re_creq_irq': drivers/infiniband/hw/bng_re/bng_fw.c:278:9: error: implicit declaration of function 'prefetch' [-Wimplicit-function-declaration] 278 | prefetch(bng_re_get_qe(hwq, sw_cons, NULL)); | ^~~~~~~~ Reported-by: kernel test robot <[email protected]> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/ Fixes: 4f830cd ("RDMA/bng_re: Add infrastructure for enabling Firmware channel") Link: https://patch.msgid.link/[email protected] Signed-off-by: Leon Romanovsky <[email protected]>
1 parent f37e286 commit 155c997

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/infiniband/hw/bng_re/bng_fw.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -525,7 +525,7 @@ static irqreturn_t bng_re_creq_irq(int irq, void *dev_instance)
525525
hwq = &creq->hwq;
526526
/* Prefetch the CREQ element */
527527
sw_cons = HWQ_CMP(hwq->cons, hwq);
528-
prefetch(bng_re_get_qe(hwq, sw_cons, NULL));
528+
bng_re_get_qe(hwq, sw_cons, NULL);
529529

530530
tasklet_schedule(&creq->creq_tasklet);
531531
return IRQ_HANDLED;

0 commit comments

Comments
 (0)