fix: crash when trying to play a sound after deactivating its active filter #189

Author: alnitak

CHANGELOG.md

@@ -1,3 +1,6 @@
+### 3.0.2 (25 Feb 2025)
+- fixed crash when trying to play a sound after deactivating its active filter #189
+
 ### 3.0.1 (20 Feb 2025)
 - fix: error while calling listPlaybackDevices() #186.
 - android example folder recreated.

example/tests/tests.dart

@@ -766,6 +766,8 @@ Future<StringBuffer> testSoundFilters() async {
       ..writeln();
   }
 
+  await SoLoud.instance.play(sound);
+
   /// Check if filter has been deactivated.
   assert(
     !filter.isActive,

pubspec.yaml

@@ -3,7 +3,7 @@ description: >-
   A low-level audio plugin for Flutter,
   mainly meant for games and immersive apps.
   Based on the SoLoud (C++) audio engine.
-version: 3.0.1
+version: 3.0.2
 homepage: https://github.com/alnitak/flutter_soloud
 maintainer: Marco Bavagnoli (@lildeimos)
 platforms:

src/filters/filters.cpp

@@ -242,7 +242,15 @@ bool Filters::removeFilter(FilterType filterType)
     if (index < 0)
         return false;
 
-    mSoloud->setGlobalFilter(index, 0);
+    if (mSound == nullptr)
+    {
+        mSoloud->setGlobalFilter(index, 0);
+    }
+    else
+    {
+        mSound->sound.get()->setFilter(index, 0);
+    }
+
     filters[index].get()->filter.reset();
 
     /// shift filters down by 1 from [index]