Test fix

Author: afernandes

src/CfCommand.ExecuteReader.cs

@@ -38,47 +38,6 @@ public IDataReader ExecuteReader(CfCommandType cmdType, string cmdText, object c
         {
             var cfParams = ConvertObjectToCfParameters(cmdParms);
             return ExecuteReader(cmdType, cmdText, cfParams);
-            try
-            {
-                IList<CfParameter> cfParams = null;
-                if (cmdParms != null)
-                {
-                    if (!(cmdParms is IEnumerable<CfParameter>))
-                    {
-
-                        var props = cmdParms as ExpandoObject as IDictionary<string, object>;
-                        if (props != null)
-                        {
-                            cfParams = new List<CfParameter>(props.Count());
-                            foreach (var p in props)
-                            {
-                                cfParams.Add(new CfParameter(p.Key, p.Value));
-                            }
-                        }
-                        else
-                        {
-                            var properties = cmdParms.GetType().GetProperties();
-                            if (properties.Any())
-                            {
-                                cfParams = new List<CfParameter>(properties.Count());
-                                foreach (var property in properties)
-                                {
-                                    cfParams.Add(new CfParameter(property.Name, property.GetValue(cmdParms, null)));
-                                }
-                            }
-                        }
-                    }
-                }
-
-                _conn.EstablishFactoryConnection();
-                PrepareCommand(cmdType, cmdText, cfParams);
-                return _cmd.ExecuteReader(CommandBehavior.CloseConnection);
-            }
-            catch (Exception ex)
-            {
-                Logger.Error(ex);
-                throw new CfException("Unknown Error (Connection Factory: ExecuteReader) " + ex.Message, ex);
-            }
         }
         #endregion
     }

test/ConnectionFactoryTest/App.config

@@ -12,6 +12,9 @@
     <compilation debug="true" targetFramework="4.0.3" />
   </system.web>
   <connectionStrings>
+    <add name="AppVeyor" connectionString="Data Source=.\sqlexpress;Initial Catalog=dtb_PortalDAT;Integrated Security=True"
+      providerName="System.Data.SqlClient" />
+    
     <add name="teste" connectionString="Data Source=.\sqlexpress;Initial Catalog=dtb_PortalDAT;Integrated Security=True"
       providerName="System.Data.SqlClient" />
   </connectionStrings>

test/ConnectionFactoryTest/UnitTest1.cs

@@ -1,4 +1,5 @@
-using ConnectionFactory;
+using System;
+using ConnectionFactory;
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 using System.Collections.Generic;
 using System.Data.Common;
@@ -9,63 +10,58 @@ namespace ConnectionFactoryTest
     [TestClass]
     public class UnitTest1
     {
+        protected static readonly bool IsAppVeyor = Environment.GetEnvironmentVariable("Appveyor")?.ToUpperInvariant() == "TRUE";
+
+        protected static string ConnName => IsAppVeyor ? "AppVeyor" : "teste";
+
         [TestMethod]
         public void TestCommandWithDynamicParameters()
         {
-            try
+            string returnValue = null;
+            using (var conn = new CfConnection(ConnName))
             {
-                using (var conn = new CfConnection("teste"))
-                {
-                    var cmd = conn.CreateCfCommand();
+                var cmd = conn.CreateCfCommand();
 
-                    DbDataReader result = (DbDataReader)cmd.ExecuteReader(CfCommandType.Text,
-                        "select * from sisuser.sis_user where login = @login",
-                        new { login = "andersonn" });
+                DbDataReader result = (DbDataReader)cmd.ExecuteReader(CfCommandType.Text,
+                    @"select *
+                          from(select 'user1' as login) as t
+                          where login = 'user1'",
+                    new { login = "user1" });
 
-                    if (result.Read())
-                    {
-                        var ret = result["login"].ToString();
-                        Assert.IsTrue(!string.IsNullOrEmpty(ret));
-                    }
+                if (result.Read())
+                {
+                    returnValue = result["login"].ToString();
                 }
-
-                Assert.IsTrue(true);
-            }
-            catch
-            {
-                Assert.Fail();
             }
+
+            Assert.AreEqual(returnValue, "user1");
+
         }
 
         [TestMethod]
         public void TestCommandWithExpandoObjectParameters()
         {
-            try
+            string returnValue = null;
+            using (var conn = new CfConnection(ConnName))
             {
-                using (var conn = new CfConnection("teste"))
-                {
-                    var cmd = conn.CreateCfCommand();
+                var cmd = conn.CreateCfCommand();
 
-                    var paramters = new ExpandoObject() as IDictionary<string, object>;
-                    paramters.Add("login", "andersonn");
+                var paramters = new ExpandoObject() as IDictionary<string, object>;
+                paramters.Add("login", "andersonn");
 
-                    DbDataReader result = (DbDataReader)cmd.ExecuteReader(CfCommandType.Text,
-                        "select * from sisuser.sis_user where login = @login",
-                        paramters);
+                DbDataReader result = (DbDataReader)cmd.ExecuteReader(CfCommandType.Text,
+                      @"select *
+                          from(select 'user1' as login) as t
+                          where login = 'user1'",
+                    paramters);
 
-                    if (result.Read())
-                    {
-                        var ret = result["login"].ToString();
-                        Assert.IsTrue(!string.IsNullOrEmpty(ret));
-                    }
+                if (result.Read())
+                {
+                    returnValue = result["login"].ToString();
                 }
-
-                Assert.IsTrue(true);
-            }
-            catch
-            {
-                Assert.Fail();
             }
+
+            Assert.AreEqual(returnValue, "user1");
         }
 
     }