Skip to content

The date validator has a different allowBlank validation #105

@frykten

Description

@frykten

Hi! 👋

While working with ember-changeset-validations, which uses this addon quite extensively, I saw there was an "inconsistency" in the behaviour of the date validator's allowBlank option, which checks nullish values and empty strings instead of using Ember's util isEmpty, as per all other validators (cf.).
I also saw that was introduced when removing Moment (cf. commit). Was it meant to be?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions