Merge pull request #217 from adamtheturtle/exception-line

Add line numbers to more error messages

Author: adamtheturtle

src/sphinx_notion/__init__.py

@@ -461,7 +461,8 @@ def _(
         for child in node.children:
             if isinstance(child, nodes.title):
                 table_no_titles_msg = (
-                    f"Table has a title '{child.astext()}', but Notion tables "
+                    f"Table has a title '{child.astext()}' on line "
+                    f"{child.line} in {child.source}, but Notion tables "
                     "do not have titles."
                 )
                 # Ignore error which is about a type error, but we want to
@@ -472,8 +473,19 @@ def _(
         table_structure = _extract_table_structure(node=node)
 
         if len(table_structure.header_rows) > 1:
+            first_header_row = table_structure.header_rows[0]
+            first_header_row_entry = first_header_row.children[0]
+            first_header_row_paragraph = first_header_row_entry.children[0]
+            first_header_row_line = first_header_row_paragraph.line
+            last_header_row = table_structure.header_rows[-1]
+            last_header_row_entry = last_header_row.children[0]
+            last_header_row_paragraph = last_header_row_entry.children[0]
+            last_header_row_line = last_header_row_paragraph.line
             table_multiple_header_rows_msg = (
-                "Tables with multiple header rows are not supported."
+                "Tables with multiple header rows are not supported. "
+                f"First header row is on line {first_header_row_line} in "
+                f"{first_header_row_paragraph.source}, last header row is on "
+                f"line {last_header_row_line}"
             )
             raise ValueError(table_multiple_header_rows_msg)
 

tests/test_integration.py

@@ -1826,7 +1826,12 @@ def test_list_table_header_maximum_one_allowed(
              - Cell a 2
     """
 
-    expected_message = r"^Tables with multiple header rows are not supported.$"
+    expected_message = (
+        r"^Tables with multiple header rows are not supported. "
+        r"First header row is on line 4 in "
+        rf"{re.escape(pattern=str(object=tmp_path / 'src' / 'index.rst'))}, "
+        r"last header row is on line 6"
+    )
     with pytest.raises(expected_exception=ValueError, match=expected_message):
         _assert_rst_converts_to_notion_objects(
             rst_content=rst_content,
@@ -1941,7 +1946,9 @@ def test_list_table_with_title_error(
     """
 
     expected_message = (
-        r"^Table has a title 'My Table Title', but Notion tables do not "
+        r"^Table has a title 'My Table Title' on line 1 in "
+        rf"{re.escape(pattern=str(object=tmp_path / 'src' / 'index.rst'))}, "
+        r"but Notion tables do not "
         r"have titles.$"
     )
     with pytest.raises(expected_exception=ValueError, match=expected_message):