Merge pull request #419 from adamtheturtle/has-children

Reduce API calls by using has_children

Author: adamtheturtle

src/_notion_scripts/upload.py

@@ -41,7 +41,7 @@ def _block_without_children(
     Return a copy of a block without children.
     """
     serialized_block = block.obj_ref.serialize_for_api()
-    if block.blocks:
+    if block.has_children:
         serialized_block[serialized_block["type"]]["children"] = []
 
     # Delete the ID, else the block will have the children from Notion.
@@ -243,7 +243,7 @@ def _block_with_uploaded_file(*, block: Block, session: Session) -> Block:
 
             block = block.__class__(file=uploaded_file, caption=block.caption)
 
-    elif isinstance(block, ParentBlock) and block.blocks:
+    elif isinstance(block, ParentBlock) and block.has_children:
         new_child_blocks = [
             _block_with_uploaded_file(block=child_block, session=session)
             for child_block in block.blocks

src/sphinx_notion/__init__.py

@@ -184,7 +184,7 @@ def _serialize_block_with_children(
     Convert a block to a JSON-serializable format which includes its children.
     """
     serialized_obj = block.obj_ref.serialize_for_api()
-    if isinstance(block, ParentBlock) and block.blocks:
+    if isinstance(block, ParentBlock) and block.has_children:
         serialized_obj[block.obj_ref.type]["children"] = [
             _serialize_block_with_children(block=child)
             for child in block.blocks

tests/test_integration.py

@@ -75,7 +75,7 @@ def _details_from_block(*, block: Block) -> dict[str, Any]:
     Create a serialized block details from a Block.
     """
     serialized_obj = block.obj_ref.serialize_for_api()
-    if isinstance(block, ParentBlock) and block.blocks:
+    if isinstance(block, ParentBlock) and block.has_children:
         serialized_obj[block.obj_ref.type]["children"] = [
             _details_from_block(block=child) for child in block.blocks
         ]