Merge pull request #237 from adamtheturtle/more-admonitions

Support all non-generic admonition types

Author: adamtheturtle

README.rst

@@ -80,7 +80,7 @@ The following syntax is supported:
 - Code blocks
 - Table of contents
 - Block quotes
-- Note, warning, and tip admonitions
+- All standard admonitions (note, warning, tip, attention, caution, danger, error, hint, important)
 - Collapsible sections (using sphinx-toolbox collapse directive)
 - Images (with URLs or local paths)
 - Videos (with URLs or local paths)

sample/index.rst

@@ -79,6 +79,30 @@ This text has :strike:`strike` formatting and :del:`deleted text` as well.
 
    This is a helpful tip that demonstrates the tip admonition support.
 
+.. attention::
+
+   This is an attention admonition that requires your attention.
+
+.. caution::
+
+   This is a caution admonition that warns about potential issues.
+
+.. danger::
+
+   This is a danger admonition that indicates a dangerous situation.
+
+.. error::
+
+   This is an error admonition that shows error information.
+
+.. hint::
+
+   This is a hint admonition that provides helpful hints.
+
+.. important::
+
+   This is an important admonition that highlights important information.
+
 .. collapse:: Click to expand this section
 
    This content is hidden by default and can be expanded by clicking the toggle.

src/sphinx_notion/__init__.py

@@ -739,6 +739,108 @@ def _(
     )
 
 
+@_process_node_to_blocks.register
+def _(
+    node: nodes.attention,
+    *,
+    section_level: int,
+) -> list[Block]:
+    """
+    Process attention admonition nodes by creating Notion Callout blocks.
+    """
+    del section_level
+    return _create_admonition_callout(
+        node=node,
+        emoji="👀",
+        background_color=BGColor.YELLOW,
+    )
+
+
+@_process_node_to_blocks.register
+def _(
+    node: nodes.caution,
+    *,
+    section_level: int,
+) -> list[Block]:
+    """
+    Process caution admonition nodes by creating Notion Callout blocks.
+    """
+    del section_level
+    return _create_admonition_callout(
+        node=node,
+        emoji="⚠️",
+        background_color=BGColor.YELLOW,
+    )
+
+
+@_process_node_to_blocks.register
+def _(
+    node: nodes.danger,
+    *,
+    section_level: int,
+) -> list[Block]:
+    """
+    Process danger admonition nodes by creating Notion Callout blocks.
+    """
+    del section_level
+    return _create_admonition_callout(
+        node=node,
+        emoji="🚨",
+        background_color=BGColor.RED,
+    )
+
+
+@_process_node_to_blocks.register
+def _(
+    node: nodes.error,
+    *,
+    section_level: int,
+) -> list[Block]:
+    """
+    Process error admonition nodes by creating Notion Callout blocks.
+    """
+    del section_level
+    return _create_admonition_callout(
+        node=node,
+        emoji="❌",
+        background_color=BGColor.RED,
+    )
+
+
+@_process_node_to_blocks.register
+def _(
+    node: nodes.hint,
+    *,
+    section_level: int,
+) -> list[Block]:
+    """
+    Process hint admonition nodes by creating Notion Callout blocks.
+    """
+    del section_level
+    return _create_admonition_callout(
+        node=node,
+        emoji="💡",
+        background_color=BGColor.GREEN,
+    )
+
+
+@_process_node_to_blocks.register
+def _(
+    node: nodes.important,
+    *,
+    section_level: int,
+) -> list[Block]:
+    """
+    Process important admonition nodes by creating Notion Callout blocks.
+    """
+    del section_level
+    return _create_admonition_callout(
+        node=node,
+        emoji="❗",
+        background_color=BGColor.RED,
+    )
+
+
 @_process_node_to_blocks.register
 def _(
     node: CollapseNode,
@@ -1057,6 +1159,78 @@ def visit_tip(self, node: nodes.Element) -> None:
 
         raise nodes.SkipNode
 
+    def visit_attention(self, node: nodes.Element) -> None:
+        """
+        Handle attention admonition nodes by creating Notion Callout blocks.
+        """
+        blocks = _process_node_to_blocks(
+            node,
+            section_level=self._section_level,
+        )
+        self._blocks.extend(blocks)
+
+        raise nodes.SkipNode
+
+    def visit_caution(self, node: nodes.Element) -> None:
+        """
+        Handle caution admonition nodes by creating Notion Callout blocks.
+        """
+        blocks = _process_node_to_blocks(
+            node,
+            section_level=self._section_level,
+        )
+        self._blocks.extend(blocks)
+
+        raise nodes.SkipNode
+
+    def visit_danger(self, node: nodes.Element) -> None:
+        """
+        Handle danger admonition nodes by creating Notion Callout blocks.
+        """
+        blocks = _process_node_to_blocks(
+            node,
+            section_level=self._section_level,
+        )
+        self._blocks.extend(blocks)
+
+        raise nodes.SkipNode
+
+    def visit_error(self, node: nodes.Element) -> None:
+        """
+        Handle error admonition nodes by creating Notion Callout blocks.
+        """
+        blocks = _process_node_to_blocks(
+            node,
+            section_level=self._section_level,
+        )
+        self._blocks.extend(blocks)
+
+        raise nodes.SkipNode
+
+    def visit_hint(self, node: nodes.Element) -> None:
+        """
+        Handle hint admonition nodes by creating Notion Callout blocks.
+        """
+        blocks = _process_node_to_blocks(
+            node,
+            section_level=self._section_level,
+        )
+        self._blocks.extend(blocks)
+
+        raise nodes.SkipNode
+
+    def visit_important(self, node: nodes.Element) -> None:
+        """
+        Handle important admonition nodes by creating Notion Callout blocks.
+        """
+        blocks = _process_node_to_blocks(
+            node,
+            section_level=self._section_level,
+        )
+        self._blocks.extend(blocks)
+
+        raise nodes.SkipNode
+
     def visit_table(self, node: nodes.Element) -> None:
         """
         Handle table nodes by creating Notion Table blocks.

tests/test_integration.py

@@ -744,6 +744,12 @@ def test_bullet_list_with_inline_formatting(
         ("note", "📝", BGColor.BLUE, "This is an important note."),
         ("warning", "⚠️", BGColor.YELLOW, "This is a warning message."),
         ("tip", "💡", BGColor.GREEN, "This is a helpful tip."),
+        ("attention", "👀", BGColor.YELLOW, "This requires your attention."),
+        ("caution", "⚠️", BGColor.YELLOW, "This is a caution message."),
+        ("danger", "🚨", BGColor.RED, "This is a danger message."),
+        ("error", "❌", BGColor.RED, "This is an error message."),
+        ("hint", "💡", BGColor.GREEN, "This is a helpful hint."),
+        ("important", "❗", BGColor.RED, "This is important information."),
     ],
 )
 def test_admonition_single_line(