Fix Bug #3567: Ensure mkdirRecurse() is correctly wrapped in try block (#3566)

* Based on an application crash output from OMV, if the client is unable to create the required path, the application crashes. Harden all calls to mkdirRecurse() by wrapping in a try block.

Author: abraunegg

src/config.d

@@ -569,10 +569,18 @@ class ApplicationConfig {
 
 		// Configuration directory should now have been correctly identified
 		if (!exists(configDirName)) {
-			// create the directory
-			mkdirRecurse(configDirName);
-			// Configure the applicable permissions for the folder
-			configDirName.setAttributes(returnRequiredDirectoryPermissions());
+			// Attempt path creation
+			try {
+				// create the configuration directory
+				mkdirRecurse(configDirName);
+				// Configure the applicable permissions for the folder
+				configDirName.setAttributes(returnRequiredDirectoryPermissions());
+			} catch (std.file.FileException e) {
+				// Creating the configuration directory failed
+				addLogEntry("ERROR: Unable to create the required application configuration directory: " ~ e.msg, ["info", "notify"]);
+				// Use exit scopes to shutdown API
+				return EXIT_FAILURE;
+			}
 		} else {
 			// The config path exists
 			// The path that exists must be a directory, not a file
@@ -2991,7 +2999,14 @@ class ApplicationConfig {
 		string bookmarksPath = buildPath(expandTilde(environment.get("HOME", "")), ".config", "gtk-3.0", "bookmarks");
 
 		// Ensure the bookmarks path exists
-		mkdirRecurse(dirName(bookmarksPath));
+		try {
+			// Attempt bookmarks path creation
+			mkdirRecurse(dirName(bookmarksPath));
+		} catch (std.file.FileException e) {
+			// Creating the bookmarks path failed
+			addLogEntry("ERROR: Unable to create the GNOME bookmark directory: " ~ e.msg, ["info", "notify"]);
+			return;
+		}
 
 		// Does the bookmark already exist?
 		string content = exists(bookmarksPath) ? readText(bookmarksPath) : "";
@@ -3118,7 +3133,14 @@ class ApplicationConfig {
 		string content;
 
 		// Ensure the xbelPath path exists
-		mkdirRecurse(dirName(xbelPath));
+		try {
+			// Attempt xbelPath creation
+			mkdirRecurse(dirName(xbelPath));
+		} catch (std.file.FileException e) {
+			// Creating the xbelPath path failed
+			addLogEntry("ERROR: Unable to create the KDE Places directory: " ~ e.msg, ["info", "notify"]);
+			return;
+		}
 
 		// Does the xbel file exist?		
 		if (exists(xbelPath)) {

src/main.d

@@ -910,11 +910,19 @@ int main(string[] cliArgs) {
 			if (!exists(singleDirectoryPath)) {
 				// The requested path to use with --single-directory does not exist locally within the configured 'sync_dir'
 				addLogEntry("WARNING: The requested path for --single-directory does not exist locally. Creating requested path within " ~ runtimeSyncDirectory, ["info", "notify"]);
-				// Make the required --single-directory path locally
-				mkdirRecurse(singleDirectoryPath);
-				// Configure the applicable permissions for the folder
-				if (debugLogging) {addLogEntry("Setting directory permissions for: " ~ singleDirectoryPath, ["debug"]);}
-				singleDirectoryPath.setAttributes(appConfig.returnRequiredDirectoryPermissions());
+				// Attempt path creation
+				try {
+					// Attempt to create the required --single-directory path locally
+					mkdirRecurse(singleDirectoryPath);
+					// Configure the applicable permissions for the folder
+					if (debugLogging) {addLogEntry("Setting directory permissions for: " ~ singleDirectoryPath, ["debug"]);}
+					singleDirectoryPath.setAttributes(appConfig.returnRequiredDirectoryPermissions());
+				} catch (std.file.FileException e) {
+					// Creating the sync directory failed
+					addLogEntry("ERROR: Unable to create the required --single-directory path: " ~ e.msg, ["info", "notify"]);
+					// Use exit scopes to shutdown API
+					return EXIT_FAILURE;
+				}
 			}
 
 			// Update the paths that we use to perform the sync actions

src/sync.d

@@ -959,8 +959,17 @@ class SyncEngine {
 							// Folder does not exist locally and needs to be created
 							addLogEntry("Creating the OneDrive Business Shared Files Local Directory: " ~ appConfig.configuredBusinessSharedFilesDirectoryName);
 
-							// Local folder does not exist, thus needs to be created
-							mkdirRecurse(appConfig.configuredBusinessSharedFilesDirectoryName);
+							if (!dryRun) {
+								// Local folder does not exist, thus needs to be created
+								try {
+									// Attempt path creation
+									mkdirRecurse(appConfig.configuredBusinessSharedFilesDirectoryName);
+								} catch (std.file.FileException e) {
+									// Creating the path failed
+									addLogEntry("ERROR: Unable to create the OneDrive Business Shared Files Local Directory: " ~ e.msg, ["info", "notify"]);
+								}
+							}
+							
 							// As this will not be created online, generate a response so it can be saved to the database
 							Item sharedFilesPath = makeItem(createFakeResponse(baseName(appConfig.configuredBusinessSharedFilesDirectoryName)));
 
@@ -14347,8 +14356,16 @@ class SyncEngine {
 						// Folder does not exist locally and needs to be created
 						addLogEntry("Creating the OneDrive Business Shared File Users Local Directory: " ~ newLocalSharedFilePath);
 
-						// Local folder does not exist, thus needs to be created
-						mkdirRecurse(newLocalSharedFilePath);
+						if (!dryRun) {
+							// Local folder does not exist, thus needs to be created
+							try {
+								// Attempt path creation
+								mkdirRecurse(newLocalSharedFilePath);
+							} catch (std.file.FileException e) {
+								// Creating the path failed
+								addLogEntry("ERROR: Unable to create the OneDrive Business Shared File Users Local Directory: " ~ e.msg, ["info", "notify"]);
+							}
+						}
 
 						// As this will not be created online, generate a response so it can be saved to the database
 						sharedFilesPath = makeItem(createFakeResponse(baseName(newLocalSharedFilePath)));