Limit max file size to load into RAM by the physical RAM size #2462
+65
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find it rather limiting to have the upper limit for the setting of a file size that can be loaded into RAM to be hard-coded as 32 Gb. That's for example how it's done in VirtualBox - the Base Memory slider is limited by the amount of installed physical RAM:
I really liked this approach, so I implemented it in this PR:
I was also considering changing the slider to show the percentage of the usable RAM instead of the absolute value, so if more RAM is added later, the upper-limit value will be automatically recomputed accordingly, but decided to stick with the simpler approach.