chore: add a delayed evaluation of UI flags #11091
Merged
+11
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Author
|
This PR is part of a stack of 4 bookmarks:
Created with jj-stack |
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This was referenced Dec 5, 2025
thomasheartman
force-pushed
the
update-useUiFlag
branch
5 times, most recently
from
9453a57 to
ee137c9
Compare
thomasheartman
commented
Dec 8, 2025
Comment on lines
+14
to
+16
| export const useUiFlag = <K extends Flag>(flag: K) => { | ||
| const evaluate = useDelayedUiFlagEvaluation(); | ||
| return evaluate(flag); |
Contributor
Author
There was a problem hiding this comment.
While this would have been nice to write just as
Suggested change
| export const useUiFlag = <K extends Flag>(flag: K) => { | |
| const evaluate = useDelayedUiFlagEvaluation(); | |
| return evaluate(flag); | |
| export const useUiFlag = useDelayedFlagEvaluation() |
React doesn't like that because the hook is somehow called outside of a different hook, etc. It gives rendering errors, anyway, but this makes it work.
Additionally, the generic type here is necessary to make TS recognize the return type correctly on the other end.
thomasheartman
force-pushed
the
update-useUiFlag
branch
from
ee137c9 to
5c121eb
Compare
Adds a new hook for UI flag evaluation that returns an evaluation function. This solves a frequent pain point where we can't check if a flag is enabled conditionally (e.g. if we don't know if we have a flag yet) because it's implemented as a hook. The new implementation uses the same evaluation as the old one, but returns the eval function after calling the hook, thereby circumventing the issue and allowing you to eval a flag anywhere in the function body.
thomasheartman
force-pushed
the
update-useUiFlag
branch
from
5c121eb to
561949a
Compare
FredrikOseberg
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new hook for UI flag evaluation that returns an evaluation function.
This solves a frequent pain point where we can't check if a flag is enabled conditionally (e.g. if we don't know if we have a flag yet) because it's implemented as a hook.
The new implementation uses the same evaluation as the old one, but returns the eval function after calling the hook, thereby circumventing the issue and allowing you to eval a flag anywhere in the function body.