fix: allow flag resolver to handle get variant flag enabled better #10951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
kwasniew
reviewed
Nov 10, 2025
| if (exp) { | ||
| if (typeof exp === 'boolean') return exp; | ||
| else if (exp.enabled) return exp.enabled; | ||
| else if (exp.enabled || exp.feature_enabled) return true; |
Contributor
There was a problem hiding this comment.
int he experimental.file we have enabled not feature_enabled. I was adding this line here: #10607
Contributor
There was a problem hiding this comment.
e.g. this is one example where we have enabled field only and my change was addressing what we actually do in the experimenta.ts
streaming: {
name: 'disabled',
enabled: parseEnvVarBoolean(
process.env.UNLEASH_EXPERIMENTAL_STREAMING,
false,
),
},
Contributor
Author
There was a problem hiding this comment.
That's what we do, but the type is:
export interface Variant {
name: string;
enabled: boolean;
payload?: Payload;
feature_enabled?: boolean;
}So we still allow you to have a feature_enabled field. We just don't treat it the same way that the regular unleash client does.
kwasniew
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an edge case in the flag resolver, where if you call
isEnabledfor a variant flag, but the flag returns a disabled (or default) variant (but its feature is enabled), then the flag should still be "enabled" iffeature_enabledis true.