Cosmetic changes to email.go for improved readability. #1096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better readability of trigger/resolve status. Especially for longer names.
Owner
|
I understand where you're coming from, but I actually think this isn't an improvement. What if the group name is very long? This means you'd be less likely to see the name of the endpoint in the preview of the title. |
Author
|
Honestly, the word arrangement is just cosmetic fluff. All I really care about is an indicator in the beginning of the subject that can be just an emoji 🔴🟢. This way I can easily distinguish what was resolved and what is still pending. |
Owner
|
I'm willing to meet you in the middle, how about you add the emoji at the beginning of the subject/title without changing anything else |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better readability of trigger/resolve status. Especially for longer names.
Summary
Better readability of trigger/resolve status. Especially for longer names.
Now email subject leads with a color emoji + "Alert triggered/resolved" for easy distinction.
Checklist
README.md, if applicable.