Fix state freeze after updating the hop count #8832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egbertbouman
force-pushed
the
fix_state
branch
from
80cf130 to
4f01385
Compare
Member
Author
|
validate |
qstokkink
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
apt.flagscan magically change to 8 (theapply_ip_filterflag). The same goes for the output ofhandle.flags(). Despite this, everything works as if the flags are still set correctly. However, since we're using this value when updating the hop count, this can freeze the download state (because theupdate_subscribeflag isn't getting set).Since we always want state updates anyway, I've manually set the flag in
_async_add_torrent.