Skip to content

Conversation

@egbertbouman
Copy link
Member

This PR does the following:

  • Updates ipv8-rust-tunnels to version 0.1.44, which:
    • Fixes hidden services
    • Moves SOCKS5 connection handling to rust
    • Moves HTTP request/response handling to rust
    • Improves HTTP tracker support by handling chunked encoding and keep-alive connections
  • Removes the Python fallback for handling tunnel data packets. The rust module is no longer optional
  • Updates the validation tests to use RustEndpoint
  • Fixes an issue with readd_bittorrent_peers, which made drops in download speed last longer than needed

@egbertbouman egbertbouman force-pushed the rust_update branch 3 times, most recently from 1ca0b21 to 78f088f Compare October 3, 2025 10:47
@egbertbouman egbertbouman marked this pull request as ready for review October 3, 2025 11:43
@egbertbouman
Copy link
Member Author

validate

Copy link
Contributor

@qstokkink qstokkink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a lot of this in the third step of the validate job:

[2025-10-03T14:25:46Z ERROR rust_endpoint] Could not send packet to W.X.Y.Z:P: Invalid argument (os error 22)

[2025-10-03T14:26:28Z ERROR rust_endpoint] Could not send packet to W.X.Y.Z:P: A socket operation was attempted to an unreachable network. (os error 10051)

I assume that's expected and I'll approve (please double-check, though).

@egbertbouman
Copy link
Member Author

Those errors are because I've bound all sockets to 127.0.0.1, so we can't accidentatly talk to the outside world. These random IPs are coming from AutoMockEndpoint, and are added to the overlays in TestBase.initialize. I could override it you don't mind the extra code.

@qstokkink
Copy link
Contributor

@egbertbouman I assumed it would be something like that. Seems fine as-is.

@egbertbouman egbertbouman merged commit a8d767b into Tribler:main Oct 3, 2025
7 checks passed
@teddyrogers teddyrogers mentioned this pull request Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants