Use db_session retry and more exception handling in upgrade #8334
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8320
This PR:
db_session'sretry* instead of manually committing and rolling back.try .. catchconstructions to be even more defensive.ANN101(ruff complained about this).*To my dismay,
retrycannot be used in a context manager. So, I had to refactor all the function bodies, the bits insidedb_session, into separate functions with adb_sessiondecorator.