-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix: added fix for prefix units not rendering in value panel #9750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ahrefabhi
wants to merge
11
commits into
main
Choose a base branch
from
issue/9362
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+252
β9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amlannandy
reviewed
Dec 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
amlannandy
previously approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Summary
β Changes
ISSUE: #9362
Note
Enhances ValueGraph to parse/render prefix and suffix units (including scientific notation), adds comprehensive tests and testids, and switches decimalPrecision fallback to nullish coalescing.
frontend/src/components/ValueGraph/index.tsx):valueintoprefixUnit,numericValue, andsuffixUnit(supports K/M/B and scientific notation) viauseMemo.value-graph-prefix-unit,value-graph-text,value-graph-suffix-unit).frontend/src/container/NewWidget/index.tsx):??fordecimalPrecisiondefault to preserve explicit falsy values.ValueGraphtests covering prefix/suffix units, K/M/B, decimals, scientific notation, and threshold styling/conflicts.Written by Cursor Bugbot for commit 4650090. This will update automatically on new commits. Configure here.