Skip to content

Conversation

@ahrefabhi
Copy link
Contributor

@ahrefabhi ahrefabhi commented Dec 2, 2025

πŸ“„ Summary


βœ… Changes

  • Added fix for value panel to render units that act as prefix instead of suffix.

ISSUE: #9362


image

Note

Enhances ValueGraph to parse/render prefix and suffix units (including scientific notation), adds comprehensive tests and testids, and switches decimalPrecision fallback to nullish coalescing.

  • Frontend
    • ValueGraph (frontend/src/components/ValueGraph/index.tsx):
      • Parse value into prefixUnit, numericValue, and suffixUnit (supports K/M/B and scientific notation) via useMemo.
      • Render prefix and suffix units with threshold-aware styling and test ids (value-graph-prefix-unit, value-graph-text, value-graph-suffix-unit).
    • NewWidget (frontend/src/container/NewWidget/index.tsx):
      • Use ?? for decimalPrecision default to preserve explicit falsy values.
  • Tests
    • Add ValueGraph tests covering prefix/suffix units, K/M/B, decimals, scientific notation, and threshold styling/conflicts.
    • Update snapshot to include new test ids and unit rendering.

Written by Cursor Bugbot for commit 4650090. This will update automatically on new commits. Configure here.

@github-actions github-actions bot added the bug Something isn't working label Dec 2, 2025
@srikanthccv srikanthccv self-requested a review December 2, 2025 08:58
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

amlannandy
amlannandy previously approved these changes Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants