fix: handle expected value less than zero (#7410)

srikanthccv · web-flow · commit 8f095dfbc9c2 · 2025-03-26T12:50:46.000Z
diff --git a/ee/query-service/anomaly/seasonal.go b/ee/query-service/anomaly/seasonal.go
@@ -313,6 +313,9 @@ func (p *BaseSeasonalProvider) getScore(
 	series, prevSeries, weekSeries, weekPrevSeries, past2SeasonSeries, past3SeasonSeries *v3.Series, value float64, idx int,
 ) float64 {
 	expectedValue := p.getExpectedValue(series, prevSeries, weekSeries, weekPrevSeries, past2SeasonSeries, past3SeasonSeries, idx)
+	if expectedValue < 0 {
+		expectedValue = p.getMovingAvg(prevSeries, movingAvgWindowSize, idx)
+	}
 	return (value - expectedValue) / p.getStdDev(weekSeries)
 }
 

Original file line number	Diff line number	Diff line change
`@@ -313,6 +313,9 @@ func (p *BaseSeasonalProvider) getScore(`
`313`	`313`	`series, prevSeries, weekSeries, weekPrevSeries, past2SeasonSeries, past3SeasonSeries *v3.Series, value float64, idx int,`
`314`	`314`	`) float64 {`
`315`	`315`	`expectedValue := p.getExpectedValue(series, prevSeries, weekSeries, weekPrevSeries, past2SeasonSeries, past3SeasonSeries, idx)`
	`316`	`+ if expectedValue < 0 {`
	`317`	`+ expectedValue = p.getMovingAvg(prevSeries, movingAvgWindowSize, idx)`
	`318`	`+ }`
`316`	`319`	`return (value - expectedValue) / p.getStdDev(weekSeries)`
`317`	`320`	`}`
`318`	`321`