#1855 Don't create component record when registering trait

Author: SanderMertens

distr/flecs.c

@@ -4079,7 +4079,7 @@ void flecs_register_flag_for_trait(
                             flecs_errstr_1(ecs_id_str(world, e)));
             }
 
-            ecs_component_record_t *cr = flecs_components_ensure(world, e);
+            ecs_component_record_t *cr = flecs_components_get(world, e);
             if (cr) {
                 changed |= flecs_set_id_flag(world, cr, flag, trait);
             }
@@ -37652,7 +37652,7 @@ void flecs_component_record_check_constraints(
                         flecs_errstr(ecs_get_path(world, rel)));
             } else {
                 ecs_throw(ECS_CONSTRAINT_VIOLATED, 
-                    "cannot use '%s' by itself: it has the Relationhip trait "
+                    "cannot use '%s' by itself: it has the Relationship trait "
                     "and must be used in pair with target",
                         flecs_errstr(ecs_get_path(world, rel)));
             }
@@ -43389,9 +43389,9 @@ void flecs_add_overrides_for_base(
             ecs_id_t to_add = 0;
             if (ECS_HAS_ID_FLAG(id, AUTO_OVERRIDE)) {
                 to_add = id & ~ECS_AUTO_OVERRIDE;
-                ecs_component_record_t *cr = flecs_components_get(
-                    world, to_add);
-                if (cr && (cr->flags & EcsIdDontFragment)) {
+
+                ecs_flags32_t cr_flags = flecs_component_get_flags(world, to_add);
+                if (cr_flags & EcsIdDontFragment) {
                     to_add = 0;
 
                     /* Add flag to base table. Cheaper to do here vs adding an

src/bootstrap.c

@@ -209,7 +209,7 @@ void flecs_register_flag_for_trait(
                             flecs_errstr_1(ecs_id_str(world, e)));
             }
 
-            ecs_component_record_t *cr = flecs_components_ensure(world, e);
+            ecs_component_record_t *cr = flecs_components_get(world, e);
             if (cr) {
                 changed |= flecs_set_id_flag(world, cr, flag, trait);
             }

src/storage/component_index.c

@@ -513,7 +513,7 @@ void flecs_component_record_check_constraints(
                         flecs_errstr(ecs_get_path(world, rel)));
             } else {
                 ecs_throw(ECS_CONSTRAINT_VIOLATED, 
-                    "cannot use '%s' by itself: it has the Relationhip trait "
+                    "cannot use '%s' by itself: it has the Relationship trait "
                     "and must be used in pair with target",
                         flecs_errstr(ecs_get_path(world, rel)));
             }

src/storage/table_graph.c

@@ -866,9 +866,9 @@ void flecs_add_overrides_for_base(
             ecs_id_t to_add = 0;
             if (ECS_HAS_ID_FLAG(id, AUTO_OVERRIDE)) {
                 to_add = id & ~ECS_AUTO_OVERRIDE;
-                ecs_component_record_t *cr = flecs_components_get(
-                    world, to_add);
-                if (cr && (cr->flags & EcsIdDontFragment)) {
+
+                ecs_flags32_t cr_flags = flecs_component_get_flags(world, to_add);
+                if (cr_flags & EcsIdDontFragment) {
                     to_add = 0;
 
                     /* Add flag to base table. Cheaper to do here vs adding an

test/addons/src/Memory.c

@@ -419,7 +419,7 @@ void Memory_sparse_component_memory(void) {
 
     {
         ecs_component_memory_t mem = ecs_component_memory_get(world);
-        test_assert(mem.bytes_sparse_components > 0);
+        test_assert(mem.bytes_sparse_components == 0);
     }
 
     ecs_new_w(world, Position);
@@ -446,7 +446,7 @@ void Memory_sparse_tag_memory(void) {
 
     {
         ecs_component_memory_t mem = ecs_component_memory_get(world);
-        test_assert(mem.bytes_sparse_components > 0);
+        test_assert(mem.bytes_sparse_components == 0);
     }
 
     ecs_add_id(world, Foo, EcsSparse);

test/core/project.json

@@ -1522,7 +1522,8 @@
                 "force_relationship_on_relationship",
                 "force_target_on_component",
                 "force_target_on_relationship",
-                "force_target_on_target"
+                "force_target_on_target",
+                "relationship_with_exclusive"
             ]
         }, {
            "id": "Trigger",

test/core/src/Pairs.c

@@ -3218,3 +3218,24 @@ void Pairs_force_target_on_target(void) {
     ecs_fini(world);
 }
 
+void Pairs_relationship_with_exclusive(void) {
+    ecs_world_t *world = ecs_mini();
+
+    ecs_entity_t Rel = ecs_new(world);
+    ecs_add_id(world, Rel, EcsRelationship);
+    ecs_add_id(world, Rel, EcsExclusive);
+
+    ecs_entity_t tgt_a = ecs_new(world);
+    ecs_entity_t tgt_b = ecs_new(world);
+
+    ecs_entity_t e = ecs_new(world);
+    ecs_add_pair(world, e, Rel, tgt_a);
+    test_assert(ecs_has_pair(world, e, Rel, tgt_a));
+    test_assert(!ecs_has_pair(world, e, Rel, tgt_b));
+
+    ecs_add_pair(world, e, Rel, tgt_b);
+    test_assert(!ecs_has_pair(world, e, Rel, tgt_a));
+    test_assert(ecs_has_pair(world, e, Rel, tgt_b));
+
+    ecs_fini(world);
+}

test/core/src/main.c

@@ -1462,6 +1462,7 @@ void Pairs_force_relationship_on_relationship(void);
 void Pairs_force_target_on_component(void);
 void Pairs_force_target_on_relationship(void);
 void Pairs_force_target_on_target(void);
+void Pairs_relationship_with_exclusive(void);
 
 // Testsuite 'Trigger'
 void Trigger_on_add_trigger_before_table(void);
@@ -8457,6 +8458,10 @@ bake_test_case Pairs_testcases[] = {
     {
         "force_target_on_target",
         Pairs_force_target_on_target
+    },
+    {
+        "relationship_with_exclusive",
+        Pairs_relationship_with_exclusive
     }
 };
 
@@ -13898,7 +13903,7 @@ static bake_test_suite suites[] = {
         "Pairs",
         NULL,
         NULL,
-        125,
+        126,
         Pairs_testcases
     },
     {