Skip to content

Rework ci #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pifopi merged 1 commit into from
Jan 25, 2026
Merged

Rework ci #1069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
144 changes: 144 additions & 0 deletions .github/workflows/cpp-ci-serial-programs-base.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,144 @@
name: C++ CI Serial Programs base
on:
workflow_call:
inputs:
os:
required: true
type: string

compiler:
required: true
type: string

upload-build:
type: boolean
default: false

run-tests:
type: boolean
default: false

run-clang-query:
type: boolean
default: false

jobs:
build:
runs-on: ${{inputs.os}}

steps:
- name: Set variables
shell: bash
run: |
if [[ "${{inputs.compiler}}" == "clang" ]]; then
if [[ "${{inputs.os}}" == windows* ]]; then
CMAKE_ADDITIONAL_FLAGS="-T ClangCL"
elif [[ "${{inputs.os}}" == ubuntu* ]]; then
CMAKE_ADDITIONAL_FLAGS="-DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++"
fi
fi
echo "CMAKE_ADDITIONAL_FLAGS=$CMAKE_ADDITIONAL_FLAGS" >> $GITHUB_ENV

if [[ "${{inputs.os}}" == "windows*" ]]; then
UPLOAD_FOLDER="Arduino-Source/SerialPrograms/bin/RelWithDebInfo"
else
UPLOAD_FOLDER="Arduino-Source/SerialPrograms/bin"
fi
echo "UPLOAD_FOLDER=$UPLOAD_FOLDER" >> $GITHUB_ENV

- name: Checkout Arduino-Source
uses: actions/checkout@v6
with:
path: 'Arduino-Source'
submodules: 'recursive'

- name: Install Qt
uses: jurplel/install-qt-action@v4
with:
version: '6.10.1'
modules: 'qtmultimedia qtserialport'

- name: Install dependencies (Ubuntu)
if: startsWith(inputs.os, 'ubuntu')
run: |
cd Arduino-Source
sudo apt update
sudo apt upgrade
sudo apt install clang-tools libopencv-dev

sudo apt install ./3rdPartyBinaries/libdpp-10.0.28-linux-x64.deb

- name: Install dependencies (Mac)
if: startsWith(inputs.os, 'mac')
run: |
cd Arduino-Source
brew install opencv onnxruntime

brew tap-new --no-git PA/libdpp
FORMULA_DIR="$(brew --repo PA/libdpp)/Formula"
mkdir -p "$FORMULA_DIR"
cp 3rdPartyBinaries/libdpp@10.0.28.rb "$FORMULA_DIR/"
brew install libdpp@10.0.28

- name: Generate binaries
run: |
cd Arduino-Source/SerialPrograms
mkdir bin
cd bin
cmake .. -DQT_MAJOR:STRING=6 ${{env.CMAKE_ADDITIONAL_FLAGS}}
cmake --build . --config RelWithDebInfo --parallel 10

- name: Prepare upload build
if: inputs.upload-build
shell: bash
run: |
echo https://github.com/${{github.repository}}/commit/${{github.sha}} > ${{env.UPLOAD_FOLDER}}/version.txt

- name: Upload Build
uses: actions/upload-artifact@v6
if: inputs.upload-build
with:
name: Serial Programs (os=${{inputs.os}} - compiler=${{inputs.compiler}})
path: ${{env.UPLOAD_FOLDER}}

- name: Checkout CommandLineTests
uses: actions/checkout@v6
if: inputs.run-tests
with:
repository: 'PokemonAutomation/CommandLineTests'
path: 'CommandLineTests'

- name: Run tests (Windows)
if: startsWith(inputs.os, 'windows') && inputs.run-tests
run: |
cd Arduino-Source/SerialPrograms/bin
$env:DISCORD_BOT_TOKEN = "Value"
$process = Start-Process -FilePath "./RelWithDebInfo/SerialPrograms.exe" `
-ArgumentList "--command-line-test-mode --command-line-test-folder ../../../CommandLineTests" `
-NoNewWindow -Wait -PassThru
if ($process.ExitCode -ne 0) {
Write-Error "Tests failed with exit code $($process.ExitCode)"
exit 1
}

- name: Run clang query
if: inputs.run-clang-query
run : |
cd Arduino-Source

cat << 'EOF' > query.txt
set output dump
match invocation(
isExpansionInFileMatching("SerialPrograms/"),
hasDeclaration(cxxConstructorDecl(ofClass(hasName("std::filesystem::path")))),
hasArgument(0, hasType(asString("std::string")))
)
EOF

files=$(jq -r '.[].file' SerialPrograms/bin/compile_commands.json)
echo "$files" | xargs --max-args=150 clang-query -p SerialPrograms/bin/ -f query.txt >> output.txt
cat output.txt
if grep --silent "Match #" output.txt; then
echo "::error Forbidden std::filesystem::path construction detected!"
exit 1
fi
9 changes: 9 additions & 0 deletions .github/workflows/cpp-ci-serial-programs-mac-intel.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
name: C++ CI Serial Programs Mac Intel
on: [push, pull_request, workflow_dispatch]

jobs:
build:
uses: ./.github/workflows/cpp-ci-serial-programs-base.yml
with:
os: macos-15-intel
compiler: default
9 changes: 9 additions & 0 deletions .github/workflows/cpp-ci-serial-programs-mac.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
name: C++ CI Serial Programs Mac
on: [push, pull_request, workflow_dispatch]

jobs:
build:
uses: ./.github/workflows/cpp-ci-serial-programs-base.yml
with:
os: macos-15
compiler: default
10 changes: 10 additions & 0 deletions .github/workflows/cpp-ci-serial-programs-ubuntu-clang.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
name: C++ CI Serial Programs Ubuntu clang
on: [push, pull_request, workflow_dispatch]

jobs:
build:
uses: ./.github/workflows/cpp-ci-serial-programs-base.yml
with:
os: ubuntu-24.04
compiler: clang
run-clang-query: true
10 changes: 10 additions & 0 deletions .github/workflows/cpp-ci-serial-programs-ubuntu-default.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
name: C++ CI Serial Programs Ubuntu Default
on: [push, pull_request, workflow_dispatch]

jobs:
build:
uses: ./.github/workflows/cpp-ci-serial-programs-base.yml
with:
os: ubuntu-24.04
compiler: default
run-clang-query: true
11 changes: 11 additions & 0 deletions .github/workflows/cpp-ci-serial-programs-windows-clang.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
name: C++ CI Serial Programs Windows Clang
on: [push, pull_request, workflow_dispatch]

jobs:
build:
uses: ./.github/workflows/cpp-ci-serial-programs-base.yml
with:
os: windows-2025
compiler: clang
upload-build: true
run-tests: true
11 changes: 11 additions & 0 deletions .github/workflows/cpp-ci-serial-programs-windows-default.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
name: C++ CI Serial Programs Windows Default
on: [push, pull_request, workflow_dispatch]

jobs:
build:
uses: ./.github/workflows/cpp-ci-serial-programs-base.yml
with:
os: windows-2025
compiler: default
upload-build: true
run-tests: true
91 changes: 0 additions & 91 deletions .github/workflows/cpp-ci-serial-programs.yml
View file
Open in desktop

This file was deleted.