tests

Author: pavel-kirienko

libudpard/udpard.c

@@ -606,8 +606,8 @@ typedef struct tx_transfer_t
     /// Constant transfer properties supplied by the client.
     /// The remote_* fields are identical to the local ones except in the case of P2P transfers, where
     /// they contain the values encoded in the P2P header. This is needed to find pending acks (to minimize duplicates),
-    /// and to report the correct values via the feedback callback.
-    /// By default, the remote_* fields equal the local ones.
+    /// and to report the correct values via the feedback callback for P2P transfers.
+    /// By default, upon construction, the remote_* fields equal the local ones, which is valid for ordinary messages.
     uint64_t          topic_hash;
     uint64_t          transfer_id;
     uint64_t          remote_topic_hash;

libudpard/udpard.h

@@ -329,7 +329,8 @@ typedef struct udpard_tx_mem_resources_t
 } udpard_tx_mem_resources_t;
 
 /// Outcome notification for a reliable transfer previously scheduled for transmission.
-/// For P2P transfers, the topic hash and the transfer-ID values specify which message this is a response to.
+/// For P2P transfers, the topic hash and the transfer-ID are taken from the request header this response targets,
+/// not from the locally assigned response metadata.
 typedef struct udpard_tx_feedback_t
 {
     uint64_t topic_hash;

tests/src/test_e2e_responses.cpp

@@ -427,6 +427,8 @@ void test_topic_with_p2p_response()
     udpard_tx_poll(&b_tx, now, UDPARD_IFACE_MASK_ALL);
     TEST_ASSERT_EQUAL_size_t(1, b_response_fb.count);
     TEST_ASSERT_TRUE(b_response_fb.success);
+    TEST_ASSERT_EQUAL_UINT64(topic_hash, b_response_fb.topic_hash);
+    TEST_ASSERT_EQUAL_UINT64(transfer_id, b_response_fb.transfer_id);
 
     // ================================================================================================================
     // CLEANUP
@@ -727,6 +729,8 @@ void test_topic_with_p2p_response_under_loss()
 
     TEST_ASSERT_EQUAL_size_t(1, b_response_fb.count);
     TEST_ASSERT_TRUE(b_response_fb.success);
+    TEST_ASSERT_EQUAL_UINT64(topic_hash, b_response_fb.topic_hash);
+    TEST_ASSERT_EQUAL_UINT64(transfer_id, b_response_fb.transfer_id);
 
     TEST_ASSERT_GREATER_OR_EQUAL_size_t(1, b_topic_ctx.message_count);
     TEST_ASSERT_EQUAL_size_t(1, a_response_ctx.response_count);