Skip to content

Revert "libcosmicAppHook: use RUSTFLAGS instead of platform specific flags" #468250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Aleksanaa merged 1 commit into from
Dec 6, 2025
Merged

Revert "libcosmicAppHook: use RUSTFLAGS instead of platform specific flags" #468250

Aleksanaa merged 1 commit into from
Dec 6, 2025

Conversation

@Pandapip1
Copy link
Member

@Pandapip1 Pandapip1 commented Dec 5, 2025 •
edited
Loading

This reverts commit d2c6221.

This is no longer needed in staging due to the proper fix #464707 having been merged

See also #467552 (comment)

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@Pandapip1
Revert "libcosmicAppHook: use RUSTFLAGS instead of platform specific …
ea27ed7 
…flags"

This reverts commit d2c6221.

This is no longer needed in staging due to the proper fix NixOS#464707 having been merged
@Pandapip1 Pandapip1 requested a review from a team December 5, 2025 22:49
@Pandapip1 Pandapip1 mentioned this pull request Dec 5, 2025
Merged
13 tasks
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 6.topic: COSMIC COSMIC is a software platform for designing beautiful user experiences labels Dec 5, 2025
@Aleksanaa
Copy link
Member

Aleksanaa commented Dec 6, 2025

Thank you! I wanted to do this yesterday but forgot it

@Aleksanaa Aleksanaa added this pull request to the merge queue Dec 6, 2025
@Aleksanaa Aleksanaa added the backport staging-25.11 Backport PR automatically label Dec 6, 2025
Merged via the queue into NixOS:staging with commit 6c27d98 Dec 6, 2025
32 of 35 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 6, 2025

Successfully created backport PR for staging-25.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Dec 6, 2025
Merged
@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Dec 6, 2025
@Pandapip1 Pandapip1 deleted the revert-cosmic-fix branch December 6, 2025 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a-kenji a-kenji Awaiting requested review from a-kenji

@ahoneybun ahoneybun Awaiting requested review from ahoneybun

@alyssais alyssais Awaiting requested review from alyssais

@drakon64 drakon64 Awaiting requested review from drakon64

@HeitorAugustoLN HeitorAugustoLN Awaiting requested review from HeitorAugustoLN

@michaelBelsanti michaelBelsanti Awaiting requested review from michaelBelsanti

@nyabinary nyabinary Awaiting requested review from nyabinary

@thefossguy thefossguy Awaiting requested review from thefossguy

Assignees

No one assigned

Labels

6.topic: COSMIC COSMIC is a software platform for designing beautiful user experiences 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. backport staging-25.11 Backport PR automatically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Pandapip1 @Aleksanaa