Skip to content

Conversation

@dasj19
Copy link
Contributor

@dasj19 dasj19 commented Jan 6, 2025

I have applied a patch in order to fix errors at compile time with the newer perl 5.40

Things done

Added patch from the debian project that addressed the issue happening when compiling with newer perl versions.
Built and tested locally.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 6, 2025
@dasj19 dasj19 force-pushed the netfree-db-perl-module-patch branch from 27ea346 to cddd7cb Compare January 10, 2025 12:24
@dasj19 dasj19 force-pushed the netfree-db-perl-module-patch branch from cddd7cb to c9b19be Compare February 13, 2025 22:59
@dasj19
Copy link
Contributor Author

dasj19 commented Feb 13, 2025

nix-review pr 371549 output:

--------- Report for 'x86_64-linux' ---------
5 packages built:
gcstar perl538Packages.NetFreeDB perl538Packages.NetFreeDB.devdoc perl540Packages.NetFreeDB perl540Packages.NetFreeDB.devdoc

@dasj19 dasj19 force-pushed the netfree-db-perl-module-patch branch from c9b19be to 5e876a4 Compare March 4, 2025 11:42
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 2, 2025
@nixpkgs-ci nixpkgs-ci bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 1, 2025
@dasj19
Copy link
Contributor Author

dasj19 commented Dec 6, 2025

This was superseded by: fd1a4b4
Closing

@dasj19 dasj19 closed this Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants