Do not neglect gap after th last field

Author: kagalenko-m-b

src/StructIO.jl

@@ -266,6 +266,7 @@ function unsafe_unpack(io, T, target, endianness, ::Type{Packed}; gaps=field_gap
         isempty(gaps) || skip(io, gaps[i])
         unsafe_unpack(io, fT, target_i, endianness, Packed)
     end
+    isempty(gaps) || skip(io, gaps[fieldcount(T) + 1])
 end
 
 # `Packed` packing strategy override for `unsafe_pack`
@@ -286,6 +287,7 @@ function unsafe_pack(
         isempty(gaps) || skip(io, gaps[i])
         unsafe_pack(io, f, endianness, Packed)
     end
+    isempty(gaps) || skip(io, gaps[fieldcount(T) + 1])
 end
 
 """
@@ -337,7 +339,7 @@ function strip_gap_nodes!(strct_expr::Expr)
         !isa(f, LineNumberNode) || continue
         if f.head === :(::)
             # collect positions of gap nodes, when encountering a structure
-            # field, 
+            # field, store the accumulated gap and reset the accumulator
             if f.args[1] === :_ 
                 if isa(f.args[2], Integer) && f.args[2] >= 0
                     push!(gap_locations, k)
@@ -354,6 +356,8 @@ function strip_gap_nodes!(strct_expr::Expr)
             end
         end
     end
+    # do not neglect the gap after the last field
+    push!(field_gap_values, gap_value)
     if all(iszero, field_gap_values)
         field_gap_values = UInt[]
     end

test/runtests.jl

@@ -43,18 +43,19 @@ end align_packed
     dummy_4::UInt16
     dummy_5::UInt64
     D::UInt8
+    dummy_6::UInt8
 end align_packed
 
 @io struct GappedStruct
     A::UInt32
-    _::1
-    _::2
+    _::3
     B::UInt16
     _::4
     C::UInt128
     _::2
     _::8
     _D::UInt8
+    _::1
 end align_packed
 
 
@@ -197,20 +198,22 @@ end
 @testset "Struct with gaps" begin
     A,B,C,D = 1,2,3,4
     gapped_struct =  GappedStruct(A, B, C, D)
-    raw_data = RawData(UInt32(A),0xBE, 0xBEEF,UInt16(B),0xDEADBEEF,UInt128(C),
-                       0xBEEF, 0xDEADBEEFDEADBEEF, UInt8(D));
-    unpacked_raw_data = RawData(UInt32(A),0x00, 0x0000,UInt16(B),0x00000000,UInt128(C),
-                       0x0000, 0x0000000000000000, UInt8(D));
+    raw_data = RawData(A, 0xBE, 0xBEEF, B, 0xDEADBEEF, C, 0xBEEF, 0xDEADBEEFDEADBEEF,
+                       D, 0xBE);
+    unpacked_raw_data = RawData(A, 0, 0, B, 0, C, 0, 0, D, 0);
     #
+    @test all(StructIO.field_gaps(GappedStruct) .== [0, 3, 4, 10, 1])
     @test packed_sizeof(RawData) == packed_sizeof(GappedStruct)
 	for endian in [:LittleEndian, :BigEndian]
         buf = IOBuffer()
         pack(buf, raw_data, endian)
         seekstart(buf)
         @test unpack(buf, GappedStruct, endian) == gapped_struct
+        @test eof(buf)
         #
         buf = IOBuffer(zeros(UInt8, packed_sizeof(GappedStruct)), read=true, write=true)
         pack(buf, gapped_struct, endian)
+        @test eof(buf)
         seekstart(buf)
         @test unpack(buf, GappedStruct, endian) == gapped_struct
         seekstart(buf)