Merge pull request #1232 from JuliaGeometry/fix-makie-warnings

Fix Makie warnings

Author: juliohm

Project.toml

@@ -30,7 +30,7 @@ CoordRefSystems = "0.18"
 DelaunayTriangulation = "1.0"
 Distances = "0.10"
 LinearAlgebra = "1.9"
-Makie = "0.22 - 0.24"
+Makie = "0.24"
 NearestNeighbors = "0.4"
 Random = "1.9"
 Rotations = "1.5.1"

ext/grid.jl

@@ -82,7 +82,8 @@ function vizgridfallback!(plot, M, pdim, edim)
 
     mesh = Makie.@lift GB.Mesh($verts, $quads, uv=$uv)
 
-    shading = edim == Val(3) ? Makie.FastShading : Makie.NoShading
+    # enable shading in 3D
+    shading = edim == Val(3)
 
     Makie.mesh!(plot, mesh, color=texture, shading=shading)
 

ext/mesh.jl

@@ -128,7 +128,7 @@ function vizmesh!(plot, ::Type{<:𝔼}, ::Val{2}, ::Val)
     end
 
     # enable shading in 3D
-    tshading = dim == 3 ? Makie.FastShading : Makie.NoShading
+    tshading = dim == 3
 
     tcoords, tconnec, tcolors, tshading
   end

ext/subdomain.jl

@@ -75,7 +75,7 @@ function vizsubdom!(plot::Viz{<:Tuple{SubCartesianGrid}}, ::Type{<:𝔼}, ::Val,
     marker = Makie.Rect{dim}(-1 .* sp, sp)
 
     # enable shading in 3D
-    shading = dim == 3 ? Makie.FastShading : Makie.NoShading
+    shading = dim == 3
 
     coords, marker, shading
   end