Added vcat for ColVecs/RowVecs (#291)

Co-authored-by: David Widmann <[email protected]>

Author: kaandocal

Project.toml

@@ -1,6 +1,6 @@
 name = "KernelFunctions"
 uuid = "ec8451be-7e33-11e9-00cf-bbf324bd1392"
-version = "0.10.4"
+version = "0.10.5"
 
 [deps]
 ChainRulesCore = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"

src/utils.jl

@@ -76,6 +76,8 @@ Base.getindex(D::ColVecs, i::CartesianIndex{1}) = view(D.X, :, i)
 Base.getindex(D::ColVecs, i) = ColVecs(view(D.X, :, i))
 Base.setindex!(D::ColVecs, v::AbstractVector, i) = setindex!(D.X, v, :, i)
 
+Base.vcat(a::ColVecs, b::ColVecs) = ColVecs(hcat(a.X, b.X))
+
 dim(x::ColVecs) = size(x.X, 1)
 
 pairwise(d::PreMetric, x::ColVecs) = Distances.pairwise(d, x.X; dims=2)
@@ -144,6 +146,8 @@ Base.getindex(D::RowVecs, i::CartesianIndex{1}) = view(D.X, i, :)
 Base.getindex(D::RowVecs, i) = RowVecs(view(D.X, i, :))
 Base.setindex!(D::RowVecs, v::AbstractVector, i) = setindex!(D.X, v, i, :)
 
+Base.vcat(a::RowVecs, b::RowVecs) = RowVecs(vcat(a.X, b.X))
+
 dim(x::RowVecs) = size(x.X, 2)
 
 pairwise(d::PreMetric, x::RowVecs) = Distances.pairwise(d, x.X; dims=1)

test/utils.jl

@@ -33,6 +33,8 @@
               pairwise(SqEuclidean(), X; dims=2)
         @test KernelFunctions.pairwise(SqEuclidean(), DX, DY) ≈
               pairwise(SqEuclidean(), X, Y; dims=2)
+        @test vcat(DX, DY) isa ColVecs
+        @test vcat(DX, DY).X == hcat(X, Y)
         K = zeros(N, N)
         KernelFunctions.pairwise!(K, SqEuclidean(), DX)
         @test K ≈ pairwise(SqEuclidean(), X; dims=2)
@@ -72,6 +74,8 @@
               pairwise(SqEuclidean(), X; dims=1)
         @test KernelFunctions.pairwise(SqEuclidean(), DX, DY) ≈
               pairwise(SqEuclidean(), X, Y; dims=1)
+        @test vcat(DX, DY) isa RowVecs
+        @test vcat(DX, DY).X == vcat(X, Y)
         K = zeros(D, D)
         KernelFunctions.pairwise!(K, SqEuclidean(), DX)
         @test K ≈ pairwise(SqEuclidean(), X; dims=1)