URGENT: BUG: Possible to 2nd Approve a request with services twice, resulting in an Approved request with unprocessed services.

[ean-audio]

There are reservations that were approved but show as pre-approved on the dashboard.

ex: 4292 and 4535

[nopivnick]

@ecb344

do you recall whether you Approved these two requests without first approving the services?

@rlho

both these requests include services however neither Pre-approve entries in the booking history contain a notation which leads me to believe Erik manually pre-approved the requests as a Liaison and then Pre-approved as an Admin to expedite the requests then Approved the request without first approving services.

can you confirm my suspicion? if I'm correct, we need logic that hides the Approve action on a request that has pending service approvals.

cc: @ean-audio

[rlho]

@ean-audio (cc: @nopivnick )
I was able to reproduce this situation.
It’s likely that you 2nd approved these requests in the Admin tab, and then—without reloading the page—you approved the same request again.
If you do that, this issue happens.
Please try to reload the page after each approval action if possible.

These requests are currently in PRE-APPROVED status, so if everything looks good, could you approve these services again?

[ecb344]

@nopivnick I do not remember... but it's definitely possible.

One thing I did notice is it took these multiple approvals (of the same approval level) for me to get this multi-room reservation to say approved... as though at one time it was showing the status for the 220 "side" of the reservation, and then at another time the 230 side. *and that was with refreshing

@rlho I definitely have not been refreshing the page. This is only necessary for performing multiple actions to the same request, is that right? In other words, I can approve more than one reservation without hitting refresh, correct?

[rlho]

@ean-audio
Basically, after completing each action, I’d like you to reload the page.
Sometimes the status doesn’t update automatically.

[nopivnick]

@ecb344

it took these multiple approvals (of the same approval level) for me to get this multi-room reservation to say approved

I'm either not understanding or I can't seem to replicate. can you give me a step-by-step how to replicate?

This is only necessary for performing multiple actions to the same request, is that right?

yes.

I can approve more than one reservation without hitting refresh, correct?

this is a totally reasonable expectation and if it's not working like so please let us know.

@rlho

can we deactivate (and make it light gray) the "2nd approve" action in the Admin context after the action has been taken?

[rlho]

@nopivnick
Since we can’t control the behavior on our side when the page isn’t reloaded, I think it’s best to force a reload after each action.

[nopivnick]

@rlho

I think it’s best to force a reload after each action.

ugh. it's going to be painful for the user to wait for a full reload after each action, plus have to reapply any filters they may have been using.

@pearmini

do you have any thoughts how we can cheat deactivating elements of the UI after taking an action without having to reload the page?