Reorder code: Add support for attaching some warnings to the line above them

[BabaR-f1]

Using gdscript-formatter 0.14.0 via AUR
with Helix 25.07.1 with formatter = { command = "gdscript-formatter", args = ["--reorder-code"] } and auto-format = true

Dunno if it is related or was fixed with cf1c680.

Before:

extends Node

@warning_ignore_start("unused_signal")
signal signal1
signal signal2
@warning_ignore_restore("unused_signal")

func f1() -> void:
	print("Hi!")

After:

extends Node

@warning_ignore_start("unused_signal")
signal signal1
signal signal2


@warning_ignore_restore("unused_signal")
func f1() -> void:
	print("Hi!")

Expected behavior:

@warning_ignore_restore should stay at the same line.

[NathanLovato]

Currently this is not supported. The annotations look for lines below them to attach to the closest line or statement or definition. They do not look for or attach to a line above them. This would need a new heuristic for relevant annotations or nodes that should stick to things that come before them.

Note that the reorder mode is never going to be perfect and that it is not meant to be used on every save. It's rather meant to be used as a command when you want help to quickly tidy up your code and then you can fine tune the spacing manually.

Also, please note that this is not something I would work on myself, but if someone wants to contribute a feature like this, it would be welcome, of course.

[NathanLovato]

Actually as I just fixed two issues on code reordering I tested this with the latest commit and it should now be fixed. I'll make a new release Please let me know if you keep having issues and we'll reopen the ticket (Or if you have a different issue, don't hesitate to make a new one.

[BabaR-f1]

I still have the same behavior with 0.17.0

[NathanLovato]

Could you please try again with the latest release, 0.18.2? I cannot reproduce the issue on your pasted code example above. If you have other cases that fail, could you please give me code snippets for failing cases?

[BabaR-f1]

I don't see the 0.18.2 release in the releases tab. And the AUR package is still at 0.18.0.

[BabaR-f1]

$ godot --version
$ 4.5.1.stable.arch_linux

$ gdscript-formatter --version
$ gdscript-formatter 0.18.2

$ hx --version
$ helix 25.07.1 (8e78600a)

[[language]]
name = "gdscript"
language-servers = ["godot"]
formatter = { command = "gdscript-formatter", args = ["--reorder-code"] }
auto-format = true

Still the same as the first post.