Fix crash when adding object via RemoteProxy

Closes #279

Author: PierreRaybaut

datalab/gui/objectview.py

@@ -222,11 +222,26 @@ def populate_tree(self) -> None:
             self.set_current_item_id(uuid)
 
     def update_tree(self) -> None:
-        """Update tree"""
+        """Update tree
+
+        Note: If an item is not found in the tree, the tree is repopulated to ensure
+        consistency between the tree and the model. This can happen in rare cases when
+        objects are added to the model but the tree was not properly updated.
+        """
         for group in self.objmodel.get_groups():
-            self.__update_item(self.get_item_from_id(get_uuid(group)), group)
+            group_item = self.get_item_from_id(get_uuid(group))
+            if group_item is None:
+                # Group item not found, repopulate tree to fix inconsistency
+                self.populate_tree()
+                return
+            self.__update_item(group_item, group)
             for obj in group:
-                self.__update_item(self.get_item_from_id(get_uuid(obj)), obj)
+                obj_item = self.get_item_from_id(get_uuid(obj))
+                if obj_item is None:
+                    # Object item not found, repopulate tree to fix inconsistency
+                    self.populate_tree()
+                    return
+                self.__update_item(obj_item, obj)
 
     def __add_to_group_item(
         self, obj: SignalObj | ImageObj, group_item: QW.QTreeWidgetItem

datalab/tests/features/common/update_tree_robustness_test.py

@@ -0,0 +1,65 @@
+# Copyright (c) DataLab Platform Developers, BSD 3-Clause license, see LICENSE file.
+
+"""
+Update tree robustness test
+---------------------------
+
+This test verifies that the object tree view handles edge cases gracefully,
+specifically when the tree becomes out of sync with the model.
+
+This is a regression test for a bug where update_tree() crashed with
+AttributeError: 'NoneType' object has no attribute 'setText' when an
+object existed in the model but had no corresponding tree item.
+
+The fix makes update_tree() defensive by calling populate_tree() if
+an item is not found.
+"""
+
+# pylint: disable=invalid-name  # Allows short reference names like x, y, ...
+# guitest: show
+
+import numpy as np
+import sigima.objects
+
+from datalab.tests import datalab_test_app_context
+
+
+def test_update_tree_with_model_tree_desync():
+    """Test that update_tree handles model/tree desynchronization gracefully.
+
+    This test simulates a scenario where an object exists in the model
+    but doesn't have a corresponding tree item, which previously caused
+    an AttributeError in update_tree().
+
+    The fix ensures update_tree() detects this and calls populate_tree()
+    to restore consistency.
+    """
+    with datalab_test_app_context(console=False) as win:
+        win.set_current_panel("image")
+
+        # Create and add a base image
+        data = np.random.rand(100, 100).astype(np.float64)
+        img1 = sigima.objects.create_image("Base Image", data)
+        win.imagepanel.add_object(img1)
+
+        # Create a second image and add it to the MODEL only (not to the tree)
+        # This simulates a desync between model and tree
+        data2 = np.random.rand(100, 100).astype(np.float64)
+        img2 = sigima.objects.create_image("Second Image", data2)
+
+        # Get current group ID
+        group_id = win.imagepanel.objview.get_current_group_id()
+
+        # Add to model ONLY (bypassing add_object_item which adds to tree)
+        win.imagepanel.objmodel.add_object(img2, group_id)
+
+        # Now the model has 2 objects but the tree only shows 1
+        # Calling update_tree() should NOT crash
+        # With the fix, it should call populate_tree() to resync
+
+        # This is the call that previously caused:
+        # AttributeError: 'NoneType' object has no attribute 'setText'
+        win.imagepanel.objview.update_tree()
+
+        # Verify objects are now in sync
+        assert len(win.imagepanel) == 2

doc/locale/fr/LC_MESSAGES/release_notes/release_1.00.po

@@ -7,7 +7,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: DataLab \n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2025-12-13 11:43+0100\n"
+"POT-Creation-Date: 2025-12-13 12:31+0100\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language: fr\n"
@@ -27,6 +27,21 @@ msgstr ""
 msgid "🛠️ Bug Fixes since version 1.0.2"
 msgstr "🛠️ Correctifs depuis la version 1.0.2"
 
+msgid "**Remote control - Crash when adding object via proxy:**"
+msgstr "**Contrôle distant - Plantage lors de l'ajout d'un objet via le proxy :**"
+
+msgid "Fixed `AttributeError: 'NoneType' object has no attribute 'setText'` crash when adding objects via `RemoteProxy.add_object()` in macros"
+msgstr "Correction du plantage `AttributeError: 'NoneType' object has no attribute 'setText'` lors de l'ajout d'objets via `RemoteProxy.add_object()` dans les macros"
+
+msgid "The crash occurred in `update_tree()` when the tree view became temporarily out of sync with the object model (e.g., when adding objects with specific metadata configurations or ROIs via remote proxy)"
+msgstr "Le plantage se produisait dans `update_tree()` lorsque la vue arborescente se désynchronisait temporairement avec le modèle d'objets (par exemple, lors de l'ajout d'objets avec des configurations de métadonnées spécifiques ou des ROIs via le proxy distant)"
+
+msgid "The tree view now rebuilds automatically if inconsistencies are detected, ensuring robust object addition in all scenarios"
+msgstr "La vue arborescente se reconstruit désormais automatiquement si des incohérences sont détectées, assurant un ajout d'objets robuste dans tous les scénarios"
+
+msgid "This closes [Issue #279](https://github.com/datalab-platform/datalab/issues/279) - AttributeError in update_tree() when adding object via RemoteProxy"
+msgstr "Ceci clôture [Issue #279](https://github.com/datalab-platform/datalab/issues/279) - AttributeError dans update_tree() lors de l'ajout d'un objet via RemoteProxy"
+
 msgid "**Icons - Qt SVG warnings on Linux:**"
 msgstr "**Icônes - Avertissements Qt SVG sous Linux :**"
 

doc/release_notes/release_1.00.md

@@ -4,6 +4,13 @@
 
 ### 🛠️ Bug Fixes since version 1.0.2 ###
 
+**Remote control - Crash when adding object via proxy:**
+
+* Fixed `AttributeError: 'NoneType' object has no attribute 'setText'` crash when adding objects via `RemoteProxy.add_object()` in macros
+* The crash occurred in `update_tree()` when the tree view became temporarily out of sync with the object model (e.g., when adding objects with specific metadata configurations or ROIs via remote proxy)
+* The tree view now rebuilds automatically if inconsistencies are detected, ensuring robust object addition in all scenarios
+* This closes [Issue #279](https://github.com/datalab-platform/datalab/issues/279) - AttributeError in update_tree() when adding object via RemoteProxy
+
 **Icons - Qt SVG warnings on Linux:**
 
 * Fixed "qt.svg: Invalid path data; path truncated" warnings appearing 4 times at startup on Linux/Ubuntu