fix: slack webhook (#3672)

Author: mbani01

pnpm-lock.yaml

@@ -20,8 +20,14 @@ async function telemetryIncrement(
   telemetry.increment(name, value, tags)
 }
 
-async function slackNotify(message: string, persona: SlackPersona) {
-  await sendSlackNotificationAsync(SlackChannel.ALERTS, persona, 'Temporal Alert', message)
+async function slackNotify(message: string, persona: SlackPersona | string) {
+  // Accept string to allow workflow code to pass string literals without importing enum
+  await sendSlackNotificationAsync(
+    SlackChannel.ALERTS,
+    persona as SlackPersona,
+    'Temporal Alert',
+    message,
+  )
   log.info('Slack notification sent from Temporal activity')
 }
 

services/archetypes/worker/src/activities/index.ts

@@ -8,10 +8,12 @@ import {
   workflowInfo,
 } from '@temporalio/workflow'
 
-import { SlackPersona } from '@crowd/slack'
-
 import * as activities from './activities'
 
+// Use string literal instead of enum to avoid bundling @slack/webhook in workflow code
+// The activity will handle the type conversion
+const SLACK_PERSONA_ERROR_REPORTER = 'ERROR_REPORTER' as const
+
 const activity = proxyActivities<typeof activities>({
   startToCloseTimeout: '10 seconds',
 })
@@ -72,12 +74,12 @@ export class WorkflowMonitoringInterceptor implements WorkflowInboundCallsInterc
           const errorDetails = getActivityRetryLimitDetails(err)
           const message = `*Workflow Failed: Activity Retry Limit Reached*\n\n*Workflow:* \`${info.workflowType}\`\n*Workflow ID:* \`${info.workflowId}\`\n*Run ID:* \`${info.runId}\`\n\n${errorDetails}`
 
-          await activity.slackNotify(message, SlackPersona.ERROR_REPORTER)
+          await activity.slackNotify(message, SLACK_PERSONA_ERROR_REPORTER)
         } else {
           // For other errors, send a simpler notification
           const message = `*Workflow Failed*\n\n*Workflow:* \`${info.workflowType}\`\n*Workflow ID:* \`${info.workflowId}\`\n*Run ID:* \`${info.runId}\`\n*Error:* ${err.message}`
 
-          await activity.slackNotify(message, SlackPersona.ERROR_REPORTER)
+          await activity.slackNotify(message, SLACK_PERSONA_ERROR_REPORTER)
         }
       }
 

services/archetypes/worker/src/interceptors.ts

@@ -14,6 +14,6 @@
   "dependencies": {
     "@crowd/common": "workspace:*",
     "@crowd/logging": "workspace:*",
-    "@slack/webhook": "^7.0.2"
+    "@slack/webhook": "^6.1.0"
   }
 }