Merge pull request #502 from CodeForPhilly/visit-ID-required-for-sep-data-473

Visit ID required for sep data closes #473

Author: alex-cots

core/sep_data/views.py

@@ -1,3 +1,4 @@
+from rest_framework.exceptions import PermissionDenied
 from core.viewsets import ModelViewSet
 from core.models import SepData
 from core.sep_data.serializers import SepDataSerializer
@@ -11,3 +12,8 @@ def get_queryset(self):
         if visit_id is not None:
             queryset = queryset.filter(visit_id=visit_id)
         return queryset
+
+    def list(self, request, *args, **kwargs):
+        if 'visit_id' not in self.request.query_params:
+            raise PermissionDenied('Sep data must be queried by visit id.')
+        return super().list(request, *args, **kwargs)

core/tests/sep_data.py

@@ -1,5 +1,4 @@
 import json
-from django.utils import timezone
 from django.urls import reverse
 from rest_framework import status
 from core.models import SepData
@@ -18,21 +17,22 @@ class Sep_DataTestCase(BaseTestCase):
 
     def test_get_sep_data_admin_and_ip(self):
         """
-        Ensure we can get a list of visits as admin and internal provider
+        Ensure even high permission users cannot access all sep data objects at once.
         """
         header1 = self.auth_headers_for_user("admin")
         url = reverse("sepdata-list")
         res1 = self.client.get(url, format="json", follow=True, **header1)
+        expected_content = {'detail': 'Sep data must be queried by visit id.'}
 
-        self.assertEqual(res1.status_code, status.HTTP_200_OK)
-        self.assertEqual(SepData.objects.count(), len(json.loads(res1.content)))
+        self.assertEqual(res1.status_code, status.HTTP_403_FORBIDDEN)
+        self.assertEqual(expected_content, json.loads(res1.content))
 
         header2 = self.auth_headers_for_user("internal_provider")
         url = reverse("sepdata-list")
         res2 = self.client.get(url, format="json", follow=True, **header2)
 
-        self.assertEqual(res2.status_code, status.HTTP_200_OK)
-        self.assertEqual(SepData.objects.count(), len(json.loads(res2.content)))
+        self.assertEqual(res2.status_code, status.HTTP_403_FORBIDDEN)
+        self.assertEqual(expected_content, json.loads(res2.content))
 
     def test_get_sep_auth_denial_unauthorized(self):
         """