Added unlisted videos limitations #308
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Betree
reviewed
Mar 31, 2021
Member
Betree
left a comment
Betree
left a comment
There was a problem hiding this comment.
Unless I'm missing something, I think we need to update
as well, otherwise we will never record anyunlisted_video.
Adding a test is also a good way to make sure that it works. That can either be done in apps/cf/test/accounts/user_permissions_test.exs or apps/cf/test/videos/videos_test.exs
wdestin
force-pushed
the
152-lower-reputation-required-for-unlisted-video
branch
from
910d40a to
3bb3b42
Compare
Contributor
Author
|
@Betree This one needs your review too. |
Betree
force-pushed
the
staging
branch
6 times, most recently
from
8edadfd to
a2007b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve CaptainFact/captain-fact#152