chore: Fix compilation warnings

Author: Betree

apps/cf/config/config.exs

@@ -1,9 +1,9 @@
 # This file is responsible for configuring your application
-# and its dependencies with the aid of the Mix.Config module.
+# and its dependencies with the aid of the Config module.
 #
 # This configuration file is loaded before any dependency and
 # is restricted to this project.
-use Mix.Config
+import Config
 
 # General application configuration
 config :cf,
@@ -41,7 +41,7 @@ config :algoliax,
   application_id: "N5GW2EAIFX"
 
 # Import environment specific config
-import_config "#{Mix.env()}.exs"
+Config.import_config("#{Mix.env()}.exs")
 
 config :cf,
   openai_model: "gpt-4o"

apps/cf/config/dev.exs

@@ -1,4 +1,4 @@
-use Mix.Config
+import Config
 
 dev_secret = "8C6FsJwjV11d+1WPUIbkEH6gB/VavJrcXWoPLujgpclfxjkLkoNFSjVU9XfeNm6s"
 
@@ -32,5 +32,5 @@ config :cf, CF.Mailer, adapter: Bamboo.LocalAdapter
 
 # Import local secrets if any - use wildcard to ignore errors
 for config <- "*dev.secret.exs" |> Path.expand(__DIR__) |> Path.wildcard() do
-  import_config config
+  Config.import_config(config)
 end

apps/cf/lib/accounts/accounts.ex

@@ -24,7 +24,7 @@ defmodule CF.Accounts do
   @request_validity 48 * 60 * 60
 
   # Configure Fetching of user picture on Gravatar
-  @fetch_default_picture Application.get_env(:cf, :fetch_default_user_picture, true)
+  @fetch_default_picture Application.compile_env(:cf, :fetch_default_user_picture, true)
 
   # ---- User creation ----
 

apps/cf/lib/accounts/username_generator.ex

@@ -1,12 +1,14 @@
 defmodule CF.Accounts.UsernameGenerator do
+  use Agent
+
   @moduledoc """
   Generates a unique username based on user id
   """
 
   @name __MODULE__
   @username_prefix "NewUser-"
 
-  def start_link do
+  def start_link(_opts \\ []) do
     Agent.start_link(
       fn ->
         Hashids.new(

apps/cf/lib/application.ex

@@ -4,16 +4,14 @@ defmodule CF.Application do
   # See http://elixir-lang.org/docs/stable/elixir/Application.html
   # for more information on OTP Applications
   def start(_type, _args) do
-    import Supervisor.Spec
-
     # Define workers and child supervisors to be supervised
     children = [
       # Other custom supervisors
-      supervisor(CF.Sources.Fetcher, []),
+      CF.Sources.Fetcher,
       # Misc workers
-      worker(CF.Accounts.UsernameGenerator, []),
+      CF.Accounts.UsernameGenerator,
       # Sweep tokens from db
-      worker(Guardian.DB.Token.SweeperServer, [])
+      Guardian.DB.Token.SweeperServer
     ]
 
     # See http://elixir-lang.org/docs/stable/elixir/Supervisor.html

apps/cf/lib/authenticator/oauth/facebook.ex

@@ -105,7 +105,7 @@ defmodule CF.Authenticator.OAuth.Facebook do
   end
 
   defp hmac(data, type, key) do
-    :crypto.hmac(type, key, data)
+    :crypto.mac(:hmac, type, key, data)
   end
 
   # ---- Private ----

apps/cf/lib/errors/errors.ex

@@ -36,30 +36,9 @@ defmodule CF.Errors do
   end
 
   @spec do_report(:error | :exit | :throw, any(), [any()], cf_error_params()) :: :ok
-  def do_report(type, value, stacktrace, params) do
+  def do_report(type, value, stacktrace, _params) do
     # Any call to Sentry, Rollbar, etc. should be done here
     Logger.error("[ERROR][#{type}] #{inspect(value)} - #{inspect(stacktrace)}")
     :ok
   end
-
-  defp build_occurence_data(params) do
-    default_occurrence_data()
-    |> add_user(params[:user])
-    |> Map.merge(params[:data] || %{})
-  end
-
-  defp default_occurrence_data() do
-    %{
-      "code_version" => CF.Application.version()
-    }
-  end
-
-  defp add_user(base, nil),
-    do: base
-
-  defp add_user(base, %{id: id, username: username}),
-    do: Map.merge(base, %{"person" => %{"id" => Integer.to_string(id), "username" => username}})
-
-  defp add_user(base, %{id: id}),
-    do: Map.merge(base, %{"person" => %{"id" => Integer.to_string(id)}})
 end

apps/cf/lib/llms/statements_creator.ex

@@ -65,9 +65,6 @@ defmodule CF.LLMs.StatementsCreator do
     end
   end
 
-  @doc """
-  Chunk captions everytime we reach the max caption length
-  """
   defp chunk_captions(captions) do
     # TODO: Add last captions from previous batch to preserve context
     Enum.chunk_every(captions, @captions_chunk_size)
@@ -138,7 +135,7 @@ defmodule CF.LLMs.StatementsCreator do
   defp create_statements_from_inputs(statements_inputs, video) do
     inserted_at = NaiveDateTime.utc_now() |> NaiveDateTime.truncate(:second)
 
-    {nb_statements, statements} =
+    {_nb_statements, statements} =
       DB.Repo.insert_all(
         DB.Schema.Statement,
         Enum.map(statements_inputs, fn %{"text" => text, "time" => time} ->

apps/cf/lib/sources/fetcher.ex

@@ -10,17 +10,25 @@ defmodule CF.Sources.Fetcher do
 
   # ---- Public API ----
 
-  def start_link() do
-    import Supervisor.Spec
+  def child_spec(opts) do
+    %{
+      id: __MODULE__,
+      start: {__MODULE__, :start_link, [opts]},
+      type: :supervisor,
+      restart: :permanent,
+      shutdown: 500
+    }
+  end
 
+  def start_link(_opts \\ []) do
     Supervisor.start_link(
       [
         :hackney_pool.child_spec(
           pool_name(),
           timeout: @request_timeout,
           max_connections: @max_connections
         ),
-        worker(CF.Sources.Fetcher.LinkChecker, [])
+        CF.Sources.Fetcher.LinkChecker
       ],
       strategy: :one_for_all,
       name: __MODULE__
@@ -75,7 +83,7 @@ defmodule CF.Sources.Fetcher do
            hackney: [pool: pool_name()]
          ) do
       {:ok, %HTTPoison.Response{status_code: 200, body: body}} ->
-        {:ok, source_params_from_tree(Floki.parse(body))}
+        {:ok, source_params_from_tree(Floki.parse_document(body))}
 
       {:ok, %HTTPoison.Response{status_code: 404}} ->
         {:error, :not_found}
@@ -137,10 +145,12 @@ defmodule CF.Sources.Fetcher do
   # Link checker
 
   defmodule LinkChecker do
+    use Agent
+
     @doc """
     Agent that record which links are currently fetched
     """
-    def start_link() do
+    def start_link(_opts \\ []) do
       Agent.start_link(fn -> MapSet.new() end, name: Fetcher.link_checker_name())
     end
 

apps/cf/lib/videos/captions_fetcher_youtube.ex

@@ -7,7 +7,6 @@ defmodule CF.Videos.CaptionsFetcherYoutube do
   @behaviour CF.Videos.CaptionsFetcher
 
   require Logger
-  import SweetXml
 
   @user_agent "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/135.0"