Skip to content

Update endpoint pattern regex for long TLD #9456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
itsjayway wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Update endpoint pattern regex for long TLD #9456

itsjayway wants to merge 6 commits into from

Conversation

@itsjayway
Copy link
Member

@itsjayway itsjayway commented Dec 5, 2025 •
edited
Loading

2,5 was too limiting for evolving customer requirements (i.e. '.microsoft'). removing the upper bound for TLD length

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
image image
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
image

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@itsjayway
Update endpoint pattern regex for long TLD
d0e94ec 
2,5 was too limiting for evolving customer requirements (i.e. '.microsoft'). removing the upper bound for TLD length
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Dec 5, 2025 •
edited
Loading

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Dec 5, 2025

Hi @itsjayway,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Dec 5, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

github-actions bot commented Dec 5, 2025 •
edited
Loading

Hi @itsjayway

⚠️ Release Requirements

Module: footprint

  • ⚠️ Please update VERSION to be 1.0.1b1 in src/footprint/setup.py

Notes

@itsjayway itsjayway marked this pull request as ready for review December 5, 2025 19:55
Copilot AI review requested due to automatic review settings December 5, 2025 19:55
@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Dec 5, 2025
Copilot AI reviewed Dec 5, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the endpoint pattern regex to support longer top-level domains (TLDs) by removing the upper bound restriction, and updates the Azure Footprint Monitoring Management API from version 2020-02-01-preview to 2024-09-16-preview.

Key Changes:

  • Regex pattern update: Changed TLD length from {2,5} to {2,} to support long TLDs like '.microsoft'
  • API version bump across all operation files from 2020-02-01-preview to 2024-09-16-preview
  • Extension version bump from 1.0.0 to 1.0.1

Reviewed changes

Copilot reviewed 34 out of 93 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/footprint/setup.py Version bump to 1.0.1
src/footprint/azext_footprint/manual/version.py Version bump to 1.0.1
src/footprint/HISTORY.rst Added changelog entry for version 1.0.1
src/footprint/azext_footprint/vendored_sdks/footprint/models/_models.py Updated endpoint regex pattern from {2,5} to {2,} for TLD length
Operation files (sync/async) Updated API version to 2024-09-16-preview across all operation modules
Client configuration files Updated API version to 2024-09-16-preview
src/footprint/azext_footprint/tests/latest/recordings/test_footprint.yaml Updated test recordings with new API version
azdev_env/* Virtual environment files that should not be committed

azdev_env/pyvenv.cfg Outdated
Comment on lines 1 to 5
home = C:\Users\jibranab\AppData\Local\Programs\Python\Python312
include-system-site-packages = false
version = 3.12.10
executable = C:\Users\jibranab\AppData\Local\Programs\Python\Python312\python.exe
command = C:\Users\jibranab\AppData\Local\Programs\Python\Python312\python.exe -m venv C:\Users\jibranab\repos\fork-az-cli-ext\azdev_env
Copy link

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The entire azdev_env directory (a virtual environment) should not be included in version control. This directory contains user-specific paths and environment configurations that will not work for other developers.

Please add azdev_env/ to your .gitignore file and remove these files from the PR.

Copilot uses AI. Check for mistakes.
@yonzhan yonzhan requested review from jsntcy and necusjz December 6, 2025 00:28
@yonzhan yonzhan requested a review from kairu-ms December 6, 2025 00:28
@necusjz
Copy link
Member

necusjz commented Dec 8, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 8, 2025

Azure Pipelines successfully started running 2 pipeline(s).

necusjz
necusjz reviewed Dec 8, 2025
View reviewed changes
src/footprint/HISTORY.rst
Comment on lines +14 to +16
1.0.1
++++++
* Relaxed the max_length on endpoint from {2,5} to {2,} to allow for longer endpoint names (long TLD).
Copy link
Member

@necusjz necusjz Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the latest version should be on the top.

necusjz
necusjz reviewed Dec 8, 2025
View reviewed changes
src/footprint/setup.py

# HISTORY.rst entry.
VERSION = '1.0.0'
VERSION = '1.0.1b1'
Copy link
Member

@necusjz necusjz Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't match the version in HISTORY.rst.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@necusjz necusjz necusjz left review comments

Copilot code review Copilot Copilot left review comments

@jsntcy jsntcy Awaiting requested review from jsntcy

@kairu-ms kairu-ms Awaiting requested review from kairu-ms

At least 1 approving review is required to merge this pull request.

Assignees

@necusjz necusjz

Labels

release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually.

Projects

None yet

Milestone

January 2026 (2026-01-06)

Development

Successfully merging this pull request may close these issues.

3 participants

@itsjayway @yonzhan @necusjz