Exclude query root from page rank calculation

Author: IvanGoncharov

src/components/settings/PageRankSlider.tsx

@@ -12,7 +12,6 @@ export default function pageRankSlider(props: PageRankSliderProps) {
   const marks = Array.from(schema.extensions.pageRanks.entries()).map(
     ([label, value]) => ({ label, value }),
   );
-  marks.push({ label: 'All types', value: 0 });
   return (
     <Slider
       aria-label="PageRank filter slider"

src/graph/type-graph.ts

@@ -6,7 +6,11 @@ import {
 } from 'graphql/type';
 
 import { VoyagerDisplayOptions } from '../components/Voyager.tsx';
-import { getEdgeTargets, isNode } from '../introspection/utils.ts';
+import {
+  getEdgeTargets,
+  isNode,
+  visitReferencedTypes,
+} from '../introspection/utils.ts';
 
 export interface TypeGraph {
   schema: GraphQLSchema;
@@ -105,28 +109,6 @@ export function getTypeGraph(
   }
 }
 
-export function visitReferencedTypes(
-  schema: GraphQLSchema,
-  rootType: GraphQLNamedType,
-  visitor: (type: GraphQLNamedType) => boolean,
-): void {
-  const seenTypes = new Set<GraphQLNamedType>();
-  walk(rootType);
-
-  function walk(type: GraphQLNamedType): void {
-    if (!isNode(type) || seenTypes.has(type)) {
-      return;
-    }
-    seenTypes.add(type);
-
-    if (visitor(type)) {
-      for (const targetType of getEdgeTargets(schema, type)) {
-        walk(targetType);
-      }
-    }
-  }
-}
-
 export function visitReferencedPaths(
   schema: GraphQLSchema,
   rootType: GraphQLNamedType,

src/introspection/introspection.ts

@@ -23,7 +23,7 @@ import { VoyagerDisplayOptions } from '../components/Voyager.tsx';
 import { collectDirectlyReferencedTypes } from '../utils/collect-referenced-types.ts';
 import { mapValues } from '../utils/mapValues.ts';
 import { transformSchema } from '../utils/transformSchema.ts';
-import { getEdgeTargets, isNode } from './utils.ts';
+import { getEdgeTargets, isNode, visitReferencedTypes } from './utils.ts';
 
 declare module 'graphql' {
   interface GraphQLFieldExtensions<_TSource, _TContext, _TArgs> {
@@ -259,12 +259,17 @@ function calculatePageRank(schema: GraphQLSchema): GraphQLSchema {
   const nodes: Array<GraphQLNamedType> = [];
   const nodeToIndex = new Map<GraphQLNamedType, number>();
 
-  for (const type of Object.values(schema.getTypeMap())) {
-    if (isNode(type)) {
-      nodeToIndex.set(type, nodes.length);
-      nodes.push(type);
-    }
-  }
+  visitReferencedTypes(
+    schema,
+    schema.getQueryType()!,
+    (type: GraphQLNamedType) => {
+      if (type != schema.getQueryType()) {
+        nodeToIndex.set(type, nodes.length);
+        nodes.push(type);
+      }
+      return true;
+    },
+  );
 
   const count = nodes.length;
   const outgoing = new Array<Array<number>>(count);
@@ -306,23 +311,21 @@ function calculatePageRank(schema: GraphQLSchema): GraphQLSchema {
   }
 
   let sum = 0;
-  const pageRanks = new Map(
-    nodes
-      .map<[string, number]>((node, index) => [node.name, ranks[index]])
-      .sort((a, b) => b[1] - a[1])
-      .map(([name, rank]) => {
-        sum += rank * 100;
-        sum = sum >= 100.0 ? 100 : sum;
-        return [name, sum];
-      }),
-  );
+  const pairs: Array<[string, number]> = nodes
+    .map<[string, number]>((node, index) => [node.name, ranks[index]])
+    .sort((a, b) => b[1] - a[1])
+    .map(([name, rank]) => {
+      sum += rank * 100;
+      sum = sum >= 100.0 ? 100 : sum;
+      return [name, sum];
+    });
 
   const schemaConfig = schema.toConfig();
   return new GraphQLSchema({
     ...schemaConfig,
     extensions: {
       ...schemaConfig.extensions,
-      pageRanks,
+      pageRanks: new Map([[schema.getQueryType()!.name, 0], ...pairs]),
     },
   });
 }

src/introspection/utils.ts

@@ -134,6 +134,28 @@ export function getEdgeTargets(
   return new Set(fieldTypes);
 }
 
+export function visitReferencedTypes(
+  schema: GraphQLSchema,
+  rootType: GraphQLNamedType,
+  visitor: (type: GraphQLNamedType) => boolean,
+): void {
+  const seenTypes = new Set<GraphQLNamedType>();
+  walk(rootType);
+
+  function walk(type: GraphQLNamedType): void {
+    if (!isNode(type) || seenTypes.has(type)) {
+      return;
+    }
+    seenTypes.add(type);
+
+    if (visitor(type)) {
+      for (const targetType of getEdgeTargets(schema, type)) {
+        walk(targetType);
+      }
+    }
+  }
+}
+
 export function isNode(type: GraphQLNamedType): type is GraphQLCompositeType {
   return (
     isCompositeType(type) &&