-
Notifications
You must be signed in to change notification settings - Fork 445
Open
Description
Security Issue: Sandbox Disabled
Severity: CRITICAL
Location: src/main/windows/main.ts:361
Description
The Electron browser window has sandbox: false explicitly set, which disables Electron's sandbox protection. This is currently required for electron-trpc but creates a significant security vulnerability.
Code
sandbox: false // Required for electron-trpc (commented)Risk
Disables Electron's sandbox protection, allowing the renderer process to access Node.js APIs if context isolation is breached.
Recommendation
- Investigate if electron-trpc has sandbox-safe alternatives
- Research alternative IPC mechanisms that support sandboxing
- Document the security tradeoff if sandboxing cannot be enabled
- Consider using
@electron/remoteor custom IPC bridge as alternatives
References
- Electron Security Documentation
- electron-trpc GitHub issues for sandbox support
Labels: security, critical, electron
Metadata
Metadata
Assignees
Labels
No labels